Re: [PATCH v2 net] dccp/tcp: do not inherit mc_list from parent

2017-05-09 Thread Eric Dumazet
On Tue, 2017-05-09 at 15:37 -0700, Cong Wang wrote: > On Tue, May 9, 2017 at 6:29 AM, Eric Dumazet wrote: > > From: Eric Dumazet > > > > syzkaller found a way to trigger double frees from ip_mc_drop_socket() > > > > It turns out that leave a copy of parent mc_list at accept() time, > > which is v

Re: [PATCH v2 net] dccp/tcp: do not inherit mc_list from parent

2017-05-09 Thread Cong Wang
On Tue, May 9, 2017 at 6:29 AM, Eric Dumazet wrote: > From: Eric Dumazet > > syzkaller found a way to trigger double frees from ip_mc_drop_socket() > > It turns out that leave a copy of parent mc_list at accept() time, > which is very bad. > > Very similar to commit 8b485ce69876 ("tcp: do not inh

Re: [PATCH v2 net] dccp/tcp: do not inherit mc_list from parent

2017-05-09 Thread David Miller
From: Eric Dumazet Date: Tue, 09 May 2017 06:29:19 -0700 > From: Eric Dumazet > > syzkaller found a way to trigger double frees from ip_mc_drop_socket() > > It turns out that leave a copy of parent mc_list at accept() time, > which is very bad. > > Very similar to commit 8b485ce69876 ("tcp: d

[PATCH v2 net] dccp/tcp: do not inherit mc_list from parent

2017-05-09 Thread Eric Dumazet
From: Eric Dumazet syzkaller found a way to trigger double frees from ip_mc_drop_socket() It turns out that leave a copy of parent mc_list at accept() time, which is very bad. Very similar to commit 8b485ce69876 ("tcp: do not inherit fastopen_req from parent") Initial report from Pray3r, compl