Re: [PATCH v2 bpf-next 5/7] bpf: sysctl for probe_on_drop

2019-05-03 Thread Lawrence Brakmo
On 4/8/19, 10:39 AM, "Yuchung Cheng" wrote: On Mon, Apr 8, 2019 at 10:07 AM Eric Dumazet wrote: > > > > On 04/08/2019 09:16 AM, Neal Cardwell wrote: > > On Wed, Apr 3, 2019 at 8:13 PM brakmo wrote: > >> > >> When a packet is dropped when calling queue_xmit in

Re: [PATCH v2 bpf-next 5/7] bpf: sysctl for probe_on_drop

2019-05-03 Thread Lawrence Brakmo
On 4/8/19, 10:07 AM, "Eric Dumazet" wrote: On 04/08/2019 09:16 AM, Neal Cardwell wrote: > On Wed, Apr 3, 2019 at 8:13 PM brakmo wrote: >> >> When a packet is dropped when calling queue_xmit in __tcp_transmit_skb >> and packets_out is 0, it is beneficial to set a

Re: [PATCH v2 bpf-next 5/7] bpf: sysctl for probe_on_drop

2019-05-03 Thread Lawrence Brakmo
Sorry for the delay, due to a combination of changing teams and getting pneumonia. Answers inline, but note that I will be sending a patchset for review that does not include these changes to the probe timer. On 4/8/19, 9:17 AM, "Neal Cardwell" wrote: On Wed, Apr 3, 2019 at 8:13 PM brakmo

Re: [PATCH v2 bpf-next 5/7] bpf: sysctl for probe_on_drop

2019-04-08 Thread Yuchung Cheng
On Mon, Apr 8, 2019 at 10:07 AM Eric Dumazet wrote: > > > > On 04/08/2019 09:16 AM, Neal Cardwell wrote: > > On Wed, Apr 3, 2019 at 8:13 PM brakmo wrote: > >> > >> When a packet is dropped when calling queue_xmit in __tcp_transmit_skb > >> and packets_out is 0, it is beneficial to set a small pr

Re: [PATCH v2 bpf-next 5/7] bpf: sysctl for probe_on_drop

2019-04-08 Thread Eric Dumazet
On 04/08/2019 09:16 AM, Neal Cardwell wrote: > On Wed, Apr 3, 2019 at 8:13 PM brakmo wrote: >> >> When a packet is dropped when calling queue_xmit in __tcp_transmit_skb >> and packets_out is 0, it is beneficial to set a small probe timer. >> Otherwise, the throughput for the flow can suffer be

Re: [PATCH v2 bpf-next 5/7] bpf: sysctl for probe_on_drop

2019-04-08 Thread Neal Cardwell
On Wed, Apr 3, 2019 at 8:13 PM brakmo wrote: > > When a packet is dropped when calling queue_xmit in __tcp_transmit_skb > and packets_out is 0, it is beneficial to set a small probe timer. > Otherwise, the throughput for the flow can suffer because it may need to > depend on the probe timer to st

[PATCH v2 bpf-next 5/7] bpf: sysctl for probe_on_drop

2019-04-03 Thread brakmo
When a packet is dropped when calling queue_xmit in __tcp_transmit_skb and packets_out is 0, it is beneficial to set a small probe timer. Otherwise, the throughput for the flow can suffer because it may need to depend on the probe timer to start sending again. The default value for the probe timer