Re: [PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it

2020-05-25 Thread Andrii Nakryiko
On Thu, May 21, 2020 at 6:07 PM Alexei Starovoitov wrote: > > On Sun, May 17, 2020 at 12:57:21PM -0700, Andrii Nakryiko wrote: > > - if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) || > > - off + size > map->value_size) { > > - verbose(env, "invalid access to m

Re: [PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it

2020-05-25 Thread Andrii Nakryiko
On Mon, May 25, 2020 at 9:01 AM Paul E. McKenney wrote: > > On Fri, May 22, 2020 at 11:46:49AM -0700, Andrii Nakryiko wrote: > > On Thu, May 21, 2020 at 5:25 PM Paul E. McKenney wrote: > > > > > > On Sun, May 17, 2020 at 12:57:21PM -0700, Andrii Nakryiko wrote: > > > > This commits adds a new MPS

Re: [PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it

2020-05-25 Thread Paul E. McKenney
On Fri, May 22, 2020 at 11:46:49AM -0700, Andrii Nakryiko wrote: > On Thu, May 21, 2020 at 5:25 PM Paul E. McKenney wrote: > > > > On Sun, May 17, 2020 at 12:57:21PM -0700, Andrii Nakryiko wrote: > > > This commits adds a new MPSC ring buffer implementation into BPF > > > ecosystem, > > > which a

Re: [PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it

2020-05-22 Thread Andrii Nakryiko
On Thu, May 21, 2020 at 6:07 PM Alexei Starovoitov wrote: > > On Sun, May 17, 2020 at 12:57:21PM -0700, Andrii Nakryiko wrote: > > - if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) || > > - off + size > map->value_size) { > > - verbose(env, "invalid access to m

Re: [PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it

2020-05-22 Thread Andrii Nakryiko
On Thu, May 21, 2020 at 5:25 PM Paul E. McKenney wrote: > > On Sun, May 17, 2020 at 12:57:21PM -0700, Andrii Nakryiko wrote: > > This commits adds a new MPSC ring buffer implementation into BPF ecosystem, > > which allows multiple CPUs to submit data to a single shared ring buffer. On > > the cons

Re: [PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it

2020-05-21 Thread Alexei Starovoitov
On Sun, May 17, 2020 at 12:57:21PM -0700, Andrii Nakryiko wrote: > - if (off < 0 || size < 0 || (size == 0 && !zero_size_allowed) || > - off + size > map->value_size) { > - verbose(env, "invalid access to map value, value_size=%d off=%d > size=%d\n", > -

Re: [PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it

2020-05-21 Thread Paul E. McKenney
On Sun, May 17, 2020 at 12:57:21PM -0700, Andrii Nakryiko wrote: > This commits adds a new MPSC ring buffer implementation into BPF ecosystem, > which allows multiple CPUs to submit data to a single shared ring buffer. On > the consumption side, only single consumer is assumed. [ . . . ] Focusing

Re: [PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it

2020-05-19 Thread kbuild test robot
Hi Andrii, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] [also build test WARNING on next-20200519] [cannot apply to bpf/master rcu/dev v5.7-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW,

Re: [PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it

2020-05-19 Thread kbuild test robot
Hi Andrii, I love your patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] [also build test WARNING on next-20200518] [cannot apply to bpf/master rcu/dev v5.7-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW,

[PATCH v2 bpf-next 1/7] bpf: implement BPF ring buffer and verifier support for it

2020-05-17 Thread Andrii Nakryiko
This commits adds a new MPSC ring buffer implementation into BPF ecosystem, which allows multiple CPUs to submit data to a single shared ring buffer. On the consumption side, only single consumer is assumed. Motivation -- There are two distinctive motivators for this work, which are not sa