Re: [PATCH v2 bpf-next 1/6] bpf: Introduce bpf sk local storage

2019-04-26 Thread Yonghong Song
On 4/26/19 11:04 AM, Martin Lau wrote: > On Fri, Apr 26, 2019 at 10:27:16AM -0700, Yonghong Song wrote: >> >> >> On 4/25/19 5:10 PM, Martin KaFai Lau wrote: >>> After allowing a bpf prog to >>> - directly read the skb->sk ptr >>> - get the fullsock bpf_sock by "bpf_sk_fullsock()" >>> - get the bp

Re: [PATCH v2 bpf-next 1/6] bpf: Introduce bpf sk local storage

2019-04-26 Thread Martin Lau
On Fri, Apr 26, 2019 at 10:27:16AM -0700, Yonghong Song wrote: > > > On 4/25/19 5:10 PM, Martin KaFai Lau wrote: > > After allowing a bpf prog to > > - directly read the skb->sk ptr > > - get the fullsock bpf_sock by "bpf_sk_fullsock()" > > - get the bpf_tcp_sock by "bpf_tcp_sock()" > > - get the

Re: [PATCH v2 bpf-next 1/6] bpf: Introduce bpf sk local storage

2019-04-26 Thread Yonghong Song
On 4/25/19 5:10 PM, Martin KaFai Lau wrote: > After allowing a bpf prog to > - directly read the skb->sk ptr > - get the fullsock bpf_sock by "bpf_sk_fullsock()" > - get the bpf_tcp_sock by "bpf_tcp_sock()" > - get the listener sock by "bpf_get_listener_sock()" > - avoid duplicating the fields of

Re: [PATCH v2 bpf-next 1/6] bpf: Introduce bpf sk local storage

2019-04-26 Thread kbuild test robot
Hi Martin, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Martin-KaFai-Lau/bpf-Introduce-bpf-sk-local-storage/20190426-192951 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master

Re: [PATCH v2 bpf-next 1/6] bpf: Introduce bpf sk local storage

2019-04-26 Thread kbuild test robot
Hi Martin, I love your patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Martin-KaFai-Lau/bpf-Introduce-bpf-sk-local-storage/20190426-192951 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master

[PATCH v2 bpf-next 1/6] bpf: Introduce bpf sk local storage

2019-04-25 Thread Martin KaFai Lau
After allowing a bpf prog to - directly read the skb->sk ptr - get the fullsock bpf_sock by "bpf_sk_fullsock()" - get the bpf_tcp_sock by "bpf_tcp_sock()" - get the listener sock by "bpf_get_listener_sock()" - avoid duplicating the fields of "(bpf_)sock" and "(bpf_)tcp_sock" into different bpf ru