Re: [PATCH v2 bpf-next 04/11] libbpf: refactor map initialization

2019-06-27 Thread Matt Hart
On Wed, 26 Jun 2019 at 19:29, Andrii Nakryiko wrote: > > On Wed, Jun 26, 2019 at 7:48 AM Matt Hart wrote: > > > > Hi all, > > > > I noticed perf fails to build for armv7 on linux next, due to this > > compile error: > > $ make -C tools/perf ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- > > > > CC

Re: [PATCH v2 bpf-next 04/11] libbpf: refactor map initialization

2019-06-26 Thread Andrii Nakryiko
On Wed, Jun 26, 2019 at 7:48 AM Matt Hart wrote: > > Hi all, > > I noticed perf fails to build for armv7 on linux next, due to this > compile error: > $ make -C tools/perf ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- > > CC libbpf_probes.o > In file included from libbpf.c:27: > libbpf.c: In

Re: [PATCH v2 bpf-next 04/11] libbpf: refactor map initialization

2019-06-26 Thread Matt Hart
Hi all, I noticed perf fails to build for armv7 on linux next, due to this compile error: $ make -C tools/perf ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- CC libbpf_probes.o In file included from libbpf.c:27: libbpf.c: In function ‘bpf_object__add_map’: /home/matt/git/linux-next/tools/inc

Re: [PATCH v2 bpf-next 04/11] libbpf: refactor map initialization

2019-06-17 Thread Song Liu
> On Jun 17, 2019, at 12:26 PM, Andrii Nakryiko wrote: > > User and global data maps initialization has gotten pretty complicated > and unnecessarily convoluted. This patch splits out the logic for global > data map and user-defined map initialization. It also removes the > restriction of pre-

[PATCH v2 bpf-next 04/11] libbpf: refactor map initialization

2019-06-17 Thread Andrii Nakryiko
User and global data maps initialization has gotten pretty complicated and unnecessarily convoluted. This patch splits out the logic for global data map and user-defined map initialization. It also removes the restriction of pre-calculating how many maps will be initialized, instead allowing to kee