Re: [PATCH v2 bpf-next] cpumap: bulk skb using netif_receive_skb_list

2021-04-15 Thread Daniel Borkmann
On 4/15/21 10:10 PM, Lorenzo Bianconi wrote: On 4/15/21 9:03 AM, Lorenzo Bianconi wrote: On 4/15/21 8:05 AM, Daniel Borkmann wrote: [...] &stats); Given we stop counting drops with the netif_receive_skb_list(), we should then also remove drops from trace_xdp_cpumap_kthread(), imho, as otherw

Re: [PATCH v2 bpf-next] cpumap: bulk skb using netif_receive_skb_list

2021-04-15 Thread Lorenzo Bianconi
> On 4/15/21 9:03 AM, Lorenzo Bianconi wrote: > >> On 4/15/21 8:05 AM, Daniel Borkmann wrote: > > > > [...] > &stats); > >>> > >>> Given we stop counting drops with the netif_receive_skb_list(), we > >>> should then > >>> also remove drops from trace_xdp_cpumap_kthread(), imho, as otherwise i

Re: [PATCH v2 bpf-next] cpumap: bulk skb using netif_receive_skb_list

2021-04-15 Thread David Ahern
On 4/15/21 9:03 AM, Lorenzo Bianconi wrote: >> On 4/15/21 8:05 AM, Daniel Borkmann wrote: > > [...] &stats); >>> >>> Given we stop counting drops with the netif_receive_skb_list(), we >>> should then >>> also remove drops from trace_xdp_cpumap_kthread(), imho, as otherwise it >>> is rather >>

Re: [PATCH v2 bpf-next] cpumap: bulk skb using netif_receive_skb_list

2021-04-15 Thread Lorenzo Bianconi
> On 4/15/21 8:05 AM, Daniel Borkmann wrote: [...] > >> &stats); > > > > Given we stop counting drops with the netif_receive_skb_list(), we > > should then > > also remove drops from trace_xdp_cpumap_kthread(), imho, as otherwise it > > is rather > > misleading (as in: drops actually happening, b

Re: [PATCH v2 bpf-next] cpumap: bulk skb using netif_receive_skb_list

2021-04-15 Thread David Ahern
On 4/15/21 8:05 AM, Daniel Borkmann wrote: > On 4/13/21 6:22 PM, Lorenzo Bianconi wrote: >> Rely on netif_receive_skb_list routine to send skbs converted from >> xdp_frames in cpu_map_kthread_run in order to improve i-cache usage. >> The proposed patch has been tested running xdp_redirect_cpu bpf s

Re: [PATCH v2 bpf-next] cpumap: bulk skb using netif_receive_skb_list

2021-04-15 Thread Jesper Dangaard Brouer
On Thu, 15 Apr 2021 17:05:36 +0200 Daniel Borkmann wrote: > On 4/13/21 6:22 PM, Lorenzo Bianconi wrote: > > Rely on netif_receive_skb_list routine to send skbs converted from > > xdp_frames in cpu_map_kthread_run in order to improve i-cache usage. > > The proposed patch has been tested running xd

Re: [PATCH v2 bpf-next] cpumap: bulk skb using netif_receive_skb_list

2021-04-15 Thread Daniel Borkmann
On 4/13/21 6:22 PM, Lorenzo Bianconi wrote: Rely on netif_receive_skb_list routine to send skbs converted from xdp_frames in cpu_map_kthread_run in order to improve i-cache usage. The proposed patch has been tested running xdp_redirect_cpu bpf sample available in the kernel tree that is used to r

Re: [PATCH v2 bpf-next] cpumap: bulk skb using netif_receive_skb_list

2021-04-13 Thread Toke Høiland-Jørgensen
Lorenzo Bianconi writes: > Rely on netif_receive_skb_list routine to send skbs converted from > xdp_frames in cpu_map_kthread_run in order to improve i-cache usage. > The proposed patch has been tested running xdp_redirect_cpu bpf sample > available in the kernel tree that is used to redirect UDP

Re: [PATCH v2 bpf-next] cpumap: bulk skb using netif_receive_skb_list

2021-04-13 Thread Jesper Dangaard Brouer
On Tue, 13 Apr 2021 18:22:02 +0200 Lorenzo Bianconi wrote: > Rely on netif_receive_skb_list routine to send skbs converted from > xdp_frames in cpu_map_kthread_run in order to improve i-cache usage. > The proposed patch has been tested running xdp_redirect_cpu bpf sample > available in the kernel

[PATCH v2 bpf-next] cpumap: bulk skb using netif_receive_skb_list

2021-04-13 Thread Lorenzo Bianconi
Rely on netif_receive_skb_list routine to send skbs converted from xdp_frames in cpu_map_kthread_run in order to improve i-cache usage. The proposed patch has been tested running xdp_redirect_cpu bpf sample available in the kernel tree that is used to redirect UDP frames from ixgbe driver to a cpum