Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-03-03 Thread Shay Agroskin
Jesper Dangaard Brouer writes: On Mon, 1 Mar 2021 13:23:06 +0200 Shay Agroskin wrote: Jesper Dangaard Brouer writes: > On Sun, 28 Feb 2021 23:27:25 +0100 > Lorenzo Bianconi wrote: > >> > > drops = bq->count - sent; >> > > -out: >> > > -bq->count = 0; >> > > +if (unlikely(dr

Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-03-02 Thread Lorenzo Bianconi
> On Mon, 1 Mar 2021 13:23:06 +0200 > Shay Agroskin wrote: > > > Jesper Dangaard Brouer writes: > > > > > On Sun, 28 Feb 2021 23:27:25 +0100 > > > Lorenzo Bianconi wrote: > > > > > >> > > drops = bq->count - sent; > > >> > > -out: > > >> > > -bq->count = 0; > > >> > > +if (unlik

Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-03-01 Thread Jesper Dangaard Brouer
On Mon, 1 Mar 2021 13:23:06 +0200 Shay Agroskin wrote: > Jesper Dangaard Brouer writes: > > > On Sun, 28 Feb 2021 23:27:25 +0100 > > Lorenzo Bianconi wrote: > > > >> > >drops = bq->count - sent; > >> > > -out: > >> > > - bq->count = 0; > >> > > + if (unlikely(drops > 0)) {

Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-03-01 Thread Ilias Apalodimas
Hi Lorenzo for the netsec driver Reviewed-by: Ilias Apalodimas On Sat, Feb 27, 2021 at 12:04:13PM +0100, Lorenzo Bianconi wrote: > We want to change the current ndo_xdp_xmit drop semantics because > it will allow us to implement better queue overflow handling. > This is working towards the larg

Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-03-01 Thread Ioana Ciornei
On Sat, Feb 27, 2021 at 12:04:13PM +0100, Lorenzo Bianconi wrote: > We want to change the current ndo_xdp_xmit drop semantics because > it will allow us to implement better queue overflow handling. > This is working towards the larger goal of a XDP TX queue-hook. > Move XDP_REDIRECT error path hand

Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-03-01 Thread Shay Agroskin
Jesper Dangaard Brouer writes: On Sun, 28 Feb 2021 23:27:25 +0100 Lorenzo Bianconi wrote: > > drops = bq->count - sent; > > -out: > > - bq->count = 0; > > + if (unlikely(drops > 0)) { > > + /* If not all frames have been > > transmitted, it is our > > + * resp

Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-02-28 Thread Jesper Dangaard Brouer
On Sun, 28 Feb 2021 23:27:25 +0100 Lorenzo Bianconi wrote: > > > drops = bq->count - sent; > > > -out: > > > - bq->count = 0; > > > + if (unlikely(drops > 0)) { > > > + /* If not all frames have been transmitted, it is our > > > + * responsibility to free them > > > +

Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-02-28 Thread Lorenzo Bianconi
> > Lorenzo Bianconi writes: > > > ... > > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c > > b/drivers/net/ethernet/amazon/ena/ena_netdev.c > > index 102f2c91fdb8..7ad0557dedbd 100644 > > --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c > > +++ b/drivers/net/ethernet/amazon/ena/ena

Re: [PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-02-28 Thread Shay Agroskin
Lorenzo Bianconi writes: ... diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index 102f2c91fdb8..7ad0557dedbd 100644 --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c ... @@ -339,8

[PATCH v2 bpf-next] bpf: devmap: move drop error path to devmap for XDP_REDIRECT

2021-02-27 Thread Lorenzo Bianconi
We want to change the current ndo_xdp_xmit drop semantics because it will allow us to implement better queue overflow handling. This is working towards the larger goal of a XDP TX queue-hook. Move XDP_REDIRECT error path handling from each XDP ethernet driver to devmap code. According to the new AP