Re: [PATCH v2 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited

2016-09-26 Thread Erik Kline
On 27 September 2016 at 11:23, Maciej Żenczykowski wrote: >> Given that some of this patch checks for == -1, and some of it checks >> for != 0... is it possible that setting the value to something >> unexpected like -3 will cause any issues to the stack? (Other than >> just rendering IPv6 unusable

Re: [PATCH v2 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited

2016-09-26 Thread Maciej Żenczykowski
> Given that some of this patch checks for == -1, and some of it checks > for != 0... is it possible that setting the value to something > unexpected like -3 will cause any issues to the stack? (Other than > just rendering IPv6 unusable on this interface, which seems like a > given.) You shouldn't

Re: [PATCH v2 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited

2016-09-26 Thread Lorenzo Colitti
On Sun, Sep 25, 2016 at 6:59 PM, Maciej Żenczykowski wrote: > + ifp->idev->cnf.rtr_solicits != 0 && Given that some of this patch checks for == -1, and some of it checks for != 0... is it possible that setting the value to something unexpected like -3 will cause any issues to the

[PATCH v2 3/7] ipv6 addrconf: rtr_solicits == -1 means unlimited

2016-09-25 Thread Maciej Żenczykowski
From: Maciej Żenczykowski This allows setting /proc/sys/net/ipv6/conf/*/router_solicitations to -1 meaning an unlimited number of retransmits. Signed-off-by: Maciej Żenczykowski --- net/ipv6/addrconf.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/net/ipv6/addr