Re: [PATCH v2 3/3] net: netcp: rework the code for get/set sw_data in dma desc

2016-02-22 Thread Murali Karicheri
On 02/19/2016 05:25 PM, Arnd Bergmann wrote: > On Friday 19 February 2016 17:21:57 Murali Karicheri wrote: get_pkt_info(&dma_buf, &tmp, &dma_desc, ndesc); -get_sw_data((u32 *)&buf_ptr, &buf_len, ndesc); +/* warning We are retrieving the virtua

Re: [PATCH v2 3/3] net: netcp: rework the code for get/set sw_data in dma desc

2016-02-19 Thread Arnd Bergmann
On Friday 19 February 2016 17:21:57 Murali Karicheri wrote: > >> get_pkt_info(&dma_buf, &tmp, &dma_desc, ndesc); > >> -get_sw_data((u32 *)&buf_ptr, &buf_len, ndesc); > >> +/* warning We are retrieving the virtual ptr in the > >> sw_data > >> + *

Re: [PATCH v2 3/3] net: netcp: rework the code for get/set sw_data in dma desc

2016-02-19 Thread Murali Karicheri
On 02/19/2016 03:55 PM, Arnd Bergmann wrote: > On Friday 19 February 2016 12:58:44 Murali Karicheri wrote: >> SW data field in descriptor can be used by software to hold private >> data for the driver. As there are 4 words available for this purpose, >> use separate macros to place it or retrieve t

Re: [PATCH v2 3/3] net: netcp: rework the code for get/set sw_data in dma desc

2016-02-19 Thread Arnd Bergmann
On Friday 19 February 2016 12:58:44 Murali Karicheri wrote: > SW data field in descriptor can be used by software to hold private > data for the driver. As there are 4 words available for this purpose, > use separate macros to place it or retrieve the same to/from > descriptors. Also do type cast o

[PATCH v2 3/3] net: netcp: rework the code for get/set sw_data in dma desc

2016-02-19 Thread Murali Karicheri
SW data field in descriptor can be used by software to hold private data for the driver. As there are 4 words available for this purpose, use separate macros to place it or retrieve the same to/from descriptors. Also do type cast of data types accordingly. Cc: Wingman Kwok Cc: Mugunthan V N CC: