Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-13 Thread jiangyiwen
On 2018/12/13 23:49, Stefan Hajnoczi wrote: > On Thu, Dec 13, 2018 at 11:08:04AM +0800, jiangyiwen wrote: >> On 2018/12/12 23:37, Michael S. Tsirkin wrote: >>> On Wed, Dec 12, 2018 at 05:29:31PM +0800, jiangyiwen wrote: When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, it will merge bi

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-13 Thread jiangyiwen
On 2018/12/13 22:50, Michael S. Tsirkin wrote: > On Thu, Dec 13, 2018 at 11:11:48AM +0800, jiangyiwen wrote: >> On 2018/12/13 3:09, David Miller wrote: >>> From: jiangyiwen >>> Date: Wed, 12 Dec 2018 17:29:31 +0800 >>> diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-13 Thread jiangyiwen
On 2018/12/13 22:48, Michael S. Tsirkin wrote: > On Thu, Dec 13, 2018 at 11:08:04AM +0800, jiangyiwen wrote: >> On 2018/12/12 23:37, Michael S. Tsirkin wrote: >>> On Wed, Dec 12, 2018 at 05:29:31PM +0800, jiangyiwen wrote: When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, it will merge

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-13 Thread Stefan Hajnoczi
On Thu, Dec 13, 2018 at 11:08:04AM +0800, jiangyiwen wrote: > On 2018/12/12 23:37, Michael S. Tsirkin wrote: > > On Wed, Dec 12, 2018 at 05:29:31PM +0800, jiangyiwen wrote: > >> When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, > >> it will merge big packet into rx vq. > >> > >> Signed-off-by: Y

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-13 Thread Stefan Hajnoczi
On Thu, Dec 13, 2018 at 03:42:33PM +0800, jiangyiwen wrote: > On 2018/12/13 13:59, David Miller wrote: > > From: jiangyiwen > > Date: Thu, 13 Dec 2018 11:11:48 +0800 > > > >> I hope Host can fill fewer bytes into rx virtqueue, so > >> I keep structure virtio_vsock_mrg_rxbuf_hdr one byte > >> alig

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-13 Thread Michael S. Tsirkin
On Thu, Dec 13, 2018 at 11:11:48AM +0800, jiangyiwen wrote: > On 2018/12/13 3:09, David Miller wrote: > > From: jiangyiwen > > Date: Wed, 12 Dec 2018 17:29:31 +0800 > > > >> diff --git a/include/uapi/linux/virtio_vsock.h > >> b/include/uapi/linux/virtio_vsock.h > >> index 1d57ed3..2292f30 100644

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-13 Thread Michael S. Tsirkin
On Thu, Dec 13, 2018 at 11:08:04AM +0800, jiangyiwen wrote: > On 2018/12/12 23:37, Michael S. Tsirkin wrote: > > On Wed, Dec 12, 2018 at 05:29:31PM +0800, jiangyiwen wrote: > >> When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, > >> it will merge big packet into rx vq. > >> > >> Signed-off-by: Y

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-12 Thread jiangyiwen
On 2018/12/13 13:59, David Miller wrote: > From: jiangyiwen > Date: Thu, 13 Dec 2018 11:11:48 +0800 > >> I hope Host can fill fewer bytes into rx virtqueue, so >> I keep structure virtio_vsock_mrg_rxbuf_hdr one byte >> alignment. > > The question is if this actully matters. > > Do you know? >

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-12 Thread David Miller
From: jiangyiwen Date: Thu, 13 Dec 2018 11:11:48 +0800 > I hope Host can fill fewer bytes into rx virtqueue, so > I keep structure virtio_vsock_mrg_rxbuf_hdr one byte > alignment. The question is if this actully matters. Do you know? If the obejct this is embeeded inside of is at least 2 byte

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-12 Thread jiangyiwen
On 2018/12/13 3:09, David Miller wrote: > From: jiangyiwen > Date: Wed, 12 Dec 2018 17:29:31 +0800 > >> diff --git a/include/uapi/linux/virtio_vsock.h >> b/include/uapi/linux/virtio_vsock.h >> index 1d57ed3..2292f30 100644 >> --- a/include/uapi/linux/virtio_vsock.h >> +++ b/include/uapi/linux/vi

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-12 Thread jiangyiwen
On 2018/12/12 23:37, Michael S. Tsirkin wrote: > On Wed, Dec 12, 2018 at 05:29:31PM +0800, jiangyiwen wrote: >> When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, >> it will merge big packet into rx vq. >> >> Signed-off-by: Yiwen Jiang > > I feel this approach jumps into making interface change

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-12 Thread David Miller
From: jiangyiwen Date: Wed, 12 Dec 2018 17:29:31 +0800 > diff --git a/include/uapi/linux/virtio_vsock.h > b/include/uapi/linux/virtio_vsock.h > index 1d57ed3..2292f30 100644 > --- a/include/uapi/linux/virtio_vsock.h > +++ b/include/uapi/linux/virtio_vsock.h > @@ -63,6 +63,11 @@ struct virtio_vso

Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-12 Thread Michael S. Tsirkin
On Wed, Dec 12, 2018 at 05:29:31PM +0800, jiangyiwen wrote: > When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, > it will merge big packet into rx vq. > > Signed-off-by: Yiwen Jiang I feel this approach jumps into making interface changes for optimizations too quickly. For example, what preve

[PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host

2018-12-12 Thread jiangyiwen
When vhost support VIRTIO_VSOCK_F_MRG_RXBUF feature, it will merge big packet into rx vq. Signed-off-by: Yiwen Jiang --- drivers/vhost/vsock.c | 111 ++ include/linux/virtio_vsock.h | 1 + include/uapi/linux/virtio_vsock.h | 5 ++ 3 files