Re: [PATCH v2 2/3] sctp_diag: export timer value only if it is active

2016-08-03 Thread Phil Sutter
On Wed, Aug 03, 2016 at 06:51:15PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Aug 03, 2016 at 11:23:12PM +0200, Phil Sutter wrote: > > Since it is exported as unsigned value, userspace has no way detecting > > whether it is negative or just very large. Therefore do this in kernel > > space whe

Re: [PATCH v2 2/3] sctp_diag: export timer value only if it is active

2016-08-03 Thread Marcelo Ricardo Leitner
On Wed, Aug 03, 2016 at 11:23:12PM +0200, Phil Sutter wrote: > Since it is exported as unsigned value, userspace has no way detecting > whether it is negative or just very large. Therefore do this in kernel > space where it is a simple comparison. > > Signed-off-by: Phil Sutter > --- > Changes si

[PATCH v2 2/3] sctp_diag: export timer value only if it is active

2016-08-03 Thread Phil Sutter
Since it is exported as unsigned value, userspace has no way detecting whether it is negative or just very large. Therefore do this in kernel space where it is a simple comparison. Signed-off-by: Phil Sutter --- Changes since v1: - Introduce local variable to shorten long lines. - Use timer_pendi