Re: [PATCH v2 2/3] broadcom: tg3: fix use of SPEED_UNKNOWN ethtool constant

2019-04-08 Thread Andrew Lunn
On Mon, Apr 08, 2019 at 10:48:46AM -0400, Michael Zhivich wrote: > tg3 driver uses u16 to store SPEED_UKNOWN ethtool constant, > which is defined as -1, resulting in value truncation and > thus incorrect test results against SPEED_UNKNOWN. > > For example, the following test will print "False": >

[PATCH v2 2/3] broadcom: tg3: fix use of SPEED_UNKNOWN ethtool constant

2019-04-08 Thread Michael Zhivich
tg3 driver uses u16 to store SPEED_UKNOWN ethtool constant, which is defined as -1, resulting in value truncation and thus incorrect test results against SPEED_UNKNOWN. For example, the following test will print "False": u16 speed = SPEED_UNKNOWN; if (speed == SPEED_UNKNOWN)