Re: [PATCH v2 2/2] net: ethernet: bgmac: mac address change bug

2017-02-03 Thread Rafał Miłecki
On 02/03/2017 10:08 PM, Jon Mason wrote: From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas Signed-off-by: Jon Maso

Re: [PATCH v2 2/2] net: ethernet: bgmac: mac address change bug

2017-02-03 Thread Florian Fainelli
On 02/03/2017 01:44 PM, Rafał Miłecki wrote: > On 02/03/2017 10:08 PM, Jon Mason wrote: >> From: Hari Vyas >> >> ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to >> bgmac_set_mac_address() but code assumed u8 *. This caused two bytes >> chopping and the wrong mac address was con

[PATCH v2 2/2] net: ethernet: bgmac: mac address change bug

2017-02-03 Thread Jon Mason
From: Hari Vyas ndo_set_mac_address() passes struct sockaddr * as 2nd parameter to bgmac_set_mac_address() but code assumed u8 *. This caused two bytes chopping and the wrong mac address was configured. Signed-off-by: Hari Vyas Signed-off-by: Jon Mason Fixes: 4e209001b86 ("bgmac: write mac ad