Re: [PATCH v2 1/7] Bluetooth: Add definitions for advertisement monitor features

2020-06-15 Thread Miao-chen Chou
Hi Marcel, https://patchwork.kernel.org/patch/11606491/ was uploaded for review. Thanks, Miao On Fri, Jun 12, 2020 at 11:17 PM Marcel Holtmann wrote: > > Hi Miao-chen, > > > The name in the mgmt-api.txt doc is "Add Advertisement Patterns > > Monitor Command", and Luiz changed the name from > >

Re: [PATCH v2 1/7] Bluetooth: Add definitions for advertisement monitor features

2020-06-12 Thread Marcel Holtmann
Hi Miao-chen, > The name in the mgmt-api.txt doc is "Add Advertisement Patterns > Monitor Command", and Luiz changed the name from > MGMT_OP_ADD_ADV_PATTERNS_MONITOR to MGMT_OP_ADD_ADV_MONITOR before > applied. So we either change the doc or change the header file to > match. Based on the outcome

Re: [PATCH v2 1/7] Bluetooth: Add definitions for advertisement monitor features

2020-06-12 Thread Miao-chen Chou
Hi Marcel, The name in the mgmt-api.txt doc is "Add Advertisement Patterns Monitor Command", and Luiz changed the name from MGMT_OP_ADD_ADV_PATTERNS_MONITOR to MGMT_OP_ADD_ADV_MONITOR before applied. So we either change the doc or change the header file to match. Based on the outcome I may need to

Re: [PATCH v2 1/7] Bluetooth: Add definitions for advertisement monitor features

2020-06-12 Thread Marcel Holtmann
Hi Miao-chen, > Thanks for reviewing. Please see v3 for the update. > I am trying to settle down the name of Add Advertisement Pattern > Monitor command with Luiz on the other thread. I will post the update > here once it is sorted out. I thought the name was just fine. Especially in the discusse

Re: [PATCH v2 1/7] Bluetooth: Add definitions for advertisement monitor features

2020-06-11 Thread Miao-chen Chou
Hi Marcel, Thanks for reviewing. Please see v3 for the update. I am trying to settle down the name of Add Advertisement Pattern Monitor command with Luiz on the other thread. I will post the update here once it is sorted out. Regards, Miao On Wed, Jun 10, 2020 at 10:57 AM Marcel Holtmann wrote:

Re: [PATCH v2 1/7] Bluetooth: Add definitions for advertisement monitor features

2020-06-10 Thread Marcel Holtmann
Hi Miao-chen, > This adds support for Advertisement Monitor API. Here are the commands > and events added. > - Read Advertisement Monitor Feature command > - Add Advertisement Pattern Monitor command > - Remove Advertisement Monitor command > - Advertisement Monitor Added event > - Advertisement M

[PATCH v2 1/7] Bluetooth: Add definitions for advertisement monitor features

2020-06-03 Thread Miao-chen Chou
This adds support for Advertisement Monitor API. Here are the commands and events added. - Read Advertisement Monitor Feature command - Add Advertisement Pattern Monitor command - Remove Advertisement Monitor command - Advertisement Monitor Added event - Advertisement Monitor Removed event Signed-