ha...@linux.intel.com;
> fred...@linux.intel.com; linux-r...@vger.kernel.org;
> dledf...@redhat.com; broo...@kernel.org; j...@nvidia.com;
> gre...@linuxfoundation.org; k...@kernel.org; Saleem, Shiraz
> ; da...@davemloft.net; Patil, Kiran
>
> Subject: Re: [
+
+ ancildrv->driver.owner = owner;
+ ancildrv->driver.bus = &ancillary_bus_type;
+ ancildrv->driver.probe = ancillary_probe_driver;
+ ancildrv->driver.remove = ancillary_remove_driver;
+ ancildrv->driver.shutdown = ancillary_shutdown_driver;
+
I think that this part is wrong, probe
On Fri, Oct 9, 2020 at 7:27 AM Pierre-Louis Bossart
wrote:
>
>
>
> +
> + ancildrv->driver.owner = owner;
> + ancildrv->driver.bus = &ancillary_bus_type;
> + ancildrv->driver.probe = ancillary_probe_driver;
> + ancildrv->driver.remove = ancillary_remove_driver;
> >>
+
+ ancildrv->driver.owner = owner;
+ ancildrv->driver.bus = &ancillary_bus_type;
+ ancildrv->driver.probe = ancillary_probe_driver;
+ ancildrv->driver.remove = ancillary_remove_driver;
+ ancildrv->driver.shutdown = ancillary_shutdown_driver;
+
I think that this part is wrong, prob
On Thu, Oct 08, 2020 at 08:29:00AM -0500, Pierre-Louis Bossart wrote:
>
> > > > > > But ... since the init() function is performing both device_init and
> > > > > > device_add - it should probably be called ancillary_device_register,
> > > > > > and we are back to a single exported API for both reg
a...@mellanox.com; Saleem, Shiraz ; Williams,
> > Dan J ; Patil, Kiran
> > Subject: Re: [PATCH v2 1/6] Add ancillary bus support
> >
> > On Mon, Oct 05, 2020 at 11:24:41AM -0700, Dave Ertman wrote:
> > > Add support for the Ancillary Bus, ancillary
v@vger.kernel.org; da...@davemloft.net; k...@kernel.org;
> gre...@linuxfoundation.org; ranjani.sridha...@linux.intel.com; pierre-
> louis.boss...@linux.intel.com; fred...@linux.intel.com;
> pa...@mellanox.com; Saleem, Shiraz ; Williams,
> Dan J ; Patil, Kiran
> Subject: Re: [PATCH v2 1/6] Add an
> netdev@vger.kernel.org; ranjani.sridha...@linux.intel.com;
> > > > fred...@linux.intel.com; linux-r...@vger.kernel.org;
> > > > dledf...@redhat.com; broo...@kernel.org; Jason Gunthorpe
> > > > ; gre...@linuxfoundation.org; k...@kernel.org;
> Williams,
> > &
ridha...@linux.intel.com;
> fred...@linux.intel.com; linux-r...@vger.kernel.org;
> dledf...@redhat.com; broo...@kernel.org; Jason Gunthorpe
> ; gre...@linuxfoundation.org; k...@kernel.org; Williams,
> Dan J ; Saleem, Shiraz
> ; da...@davemloft.net; Patil, Kiran
>
> Subject:
> From: Ertman, David M
> Sent: Thursday, October 8, 2020 10:24 PM
> > From: Parav Pandit
> > Sent: Wednesday, October 7, 2020 9:56 PM
> > /**
> > * ancillar_device_register() - register an ancillary device
> > * NOTE: __never directly free @adev after calling this function, even
> > if it
v@vger.kernel.org; da...@davemloft.net; k...@kernel.org;
> gre...@linuxfoundation.org; ranjani.sridha...@linux.intel.com; pierre-
> louis.boss...@linux.intel.com; fred...@linux.intel.com;
> pa...@mellanox.com; Saleem, Shiraz ; Williams,
> Dan J ; Patil, Kiran
> Subject: Re: [PATCH v2 1/6] A
; > Gunthorpe ; gre...@linuxfoundation.org;
> > k...@kernel.org; Saleem, Shiraz ;
> > da...@davemloft.net; Patil, Kiran
> > Subject: Re: [PATCH v2 1/6] Add ancillary bus support
> >
> > On Thu, Oct 08, 2020 at 12:38:00AM -0700, Dan Williams wrote:
> > > On Thu,
On Mon, Oct 05, 2020 at 11:24:41AM -0700, Dave Ertman wrote:
> Add support for the Ancillary Bus, ancillary_device and ancillary_driver.
> It enables drivers to create an ancillary_device and bind an
> ancillary_driver to it.
>
> The bus supports probe/remove shutdown and suspend/resume callbacks.
ridha...@linux.intel.com;
> fred...@linux.intel.com; linux-r...@vger.kernel.org;
> dledf...@redhat.com; broo...@kernel.org; Jason Gunthorpe
> ; gre...@linuxfoundation.org; k...@kernel.org; Williams,
> Dan J ; Saleem, Shiraz
> ; da...@davemloft.net; Patil, Kiran
>
> Subject:
m; ti...@suse.de; netdev@vger.kernel.org;
> ranjani.sridha...@linux.intel.com; fred...@linux.intel.com; linux-
> r...@vger.kernel.org; dledf...@redhat.com; broo...@kernel.org; Jason
> Gunthorpe ; gre...@linuxfoundation.org;
> k...@kernel.org; Saleem, Shiraz ;
> da...@davemloft.net; Patil, K
; pa...@mellanox.com; ti...@suse.de; netdev@vger.kernel.org;
> ranjani.sridha...@linux.intel.com; fred...@linux.intel.com; linux-
> r...@vger.kernel.org; dledf...@redhat.com; broo...@kernel.org; Jason
> Gunthorpe ; k...@kernel.org; Saleem, Shiraz
> ; da...@davemloft.net; Patil, Kiran
But ... since the init() function is performing both device_init and
device_add - it should probably be called ancillary_device_register,
and we are back to a single exported API for both register and
unregister.
Kind reminder that we introduced the two functions to allow the
caller to know i
> From: gre...@linuxfoundation.org
> Sent: Thursday, October 8, 2020 1:21 PM
>
> On Thu, Oct 08, 2020 at 12:38:00AM -0700, Dan Williams wrote:
> > On Thu, Oct 8, 2020 at 12:01 AM Leon Romanovsky
> wrote:
> > [..]
> > > All stated above is my opinion, it can be different from yours.
> >
> > Yes
sky
> > > > > > >> Cc: alsa-de...@alsa-project.org; pa...@mellanox.com;
> > > > > > >> ti...@suse.de; netdev@vger.kernel.org;
> > > > > > >> ranjani.sridha...@linux.intel.com;
> > > > > > >> fred...@linux
> > > >> ranjani.sridha...@linux.intel.com;
> > > > > >> fred...@linux.intel.com; linux-r...@vger.kernel.org;
> > > > > >> dledf...@redhat.com; broo...@kernel.org; Jason Gunthorpe
> > > > > >> ; gre...@linuxfoun
On Thu, Oct 8, 2020 at 1:00 AM Leon Romanovsky wrote:
>
> On Thu, Oct 08, 2020 at 12:38:00AM -0700, Dan Williams wrote:
> > On Thu, Oct 8, 2020 at 12:01 AM Leon Romanovsky wrote:
> > [..]
> > > All stated above is my opinion, it can be different from yours.
> >
> > Yes, but we need to converge to
On Thu, Oct 08, 2020 at 12:38:00AM -0700, Dan Williams wrote:
> On Thu, Oct 8, 2020 at 12:01 AM Leon Romanovsky wrote:
> [..]
> > All stated above is my opinion, it can be different from yours.
>
> Yes, but we need to converge to move this forward. Jason was involved
> in the current organization
On Thu, Oct 08, 2020 at 12:38:00AM -0700, Dan Williams wrote:
> On Thu, Oct 8, 2020 at 12:01 AM Leon Romanovsky wrote:
> [..]
> > All stated above is my opinion, it can be different from yours.
>
> Yes, but we need to converge to move this forward. Jason was involved
> in the current organization
ti...@suse.de; netdev@vger.kernel.org;
> > > > >> ranjani.sridha...@linux.intel.com;
> > > > >> fred...@linux.intel.com; linux-r...@vger.kernel.org;
> > > > >> dledf...@redhat.com; broo...@kernel.org; Jason Gunthorpe
> > > > >> ; gre...@
On Thu, Oct 8, 2020 at 12:01 AM Leon Romanovsky wrote:
[..]
> All stated above is my opinion, it can be different from yours.
Yes, but we need to converge to move this forward. Jason was involved
in the current organization for registration, Greg was angling for
this to be core functionality. I h
rnel.org;
> > > >> dledf...@redhat.com; broo...@kernel.org; Jason Gunthorpe
> > > >> ; gre...@linuxfoundation.org; k...@kernel.org;
> > > >> Williams, Dan J ; Saleem, Shiraz
> > > >> ; da...@davemloft.net; Patil, Kiran
&g
vger.kernel.org; ranjani.sridha...@linux.intel.com;
> > > > fred...@linux.intel.com; linux-r...@vger.kernel.org;
> > > > dledf...@redhat.com; broo...@kernel.org; Jason Gunthorpe
> > > > ; gre...@linuxfoundation.org; k...@kernel.org;
> > > &
.kernel.org;
> > > dledf...@redhat.com; broo...@kernel.org; Jason Gunthorpe
> > > ; gre...@linuxfoundation.org; k...@kernel.org; Williams,
> > > Dan J ; Saleem, Shiraz
> > > ; da...@davemloft.net; Patil, Kiran
> > >
> > > Subject: RE: [PATCH v2 1/6] Add anci
.kernel.org; ranjani.sridha...@linux.intel.com;
> > >> fred...@linux.intel.com; linux-r...@vger.kernel.org;
> > >> dledf...@redhat.com; broo...@kernel.org; Jason Gunthorpe
> > >> ; gre...@linuxfoundation.org; k...@kernel.org;
> > >> Williams, Dan J ; Sa
rg; k...@kernel.org; Williams,
> > Dan J ; Saleem, Shiraz
> > ; da...@davemloft.net; Patil, Kiran
> >
> > Subject: RE: [PATCH v2 1/6] Add ancillary bus support
> >
> >
> > > From: Leon Romanovsky
> > > Sent: Thursday, October 8, 2020 12:56 AM
&
t; dledf...@redhat.com; broo...@kernel.org; Jason Gunthorpe
> >> ; gre...@linuxfoundation.org; k...@kernel.org;
> >> Williams, Dan J ; Saleem, Shiraz
> >> ; da...@davemloft.net; Patil, Kiran
> >>
> >> Subject: Re: [PATCH v2 1/6] Add ancillary bus s
; ranjani.sridha...@linux.intel.com;
fred...@linux.intel.com; linux-r...@vger.kernel.org;
dledf...@redhat.com; broo...@kernel.org; Jason Gunthorpe
; gre...@linuxfoundation.org; k...@kernel.org; Williams,
Dan J ; Saleem, Shiraz
; da...@davemloft.net; Patil, Kiran
Subject: Re: [PATCH v2 1/6] Add ancillary bus
nux.intel.com;
> fred...@linux.intel.com; linux-r...@vger.kernel.org;
> dledf...@redhat.com; broo...@kernel.org; Jason Gunthorpe
> ; gre...@linuxfoundation.org; k...@kernel.org; Williams,
> Dan J ; Saleem, Shiraz
> ; da...@davemloft.net; Patil, Kiran
>
> Subject: Re
Below is most simple, intuitive and matching with core APIs for name and
design pattern wise.
init()
{
err = ancillary_device_initialize();
if (err)
return ret;
err = ancillary_device_add();
if (ret)
goto err_unwind;
err
ridha...@linux.intel.com;
> fred...@linux.intel.com; linux-r...@vger.kernel.org;
> dledf...@redhat.com; broo...@kernel.org; Jason Gunthorpe
> ; gre...@linuxfoundation.org; k...@kernel.org; Williams,
> Dan J ; Saleem, Shiraz
> ; da...@davemloft.net; Patil, Kiran
>
> Subject:
linux.intel.com; fred...@linux.intel.com; linux-
> r...@vger.kernel.org; dledf...@redhat.com; broo...@kernel.org;
> j...@nvidia.com; gre...@linuxfoundation.org; k...@kernel.org; Williams,
> Dan J ; Saleem, Shiraz
> ; da...@davemloft.net; Patil, Kiran
>
> Subject: Re: [PATCH v2 1/6] Add ancillary b
tel.com; Pierre-Louis
> Bossart ; fred...@linux.intel.com;
> linux-r...@vger.kernel.org; dledf...@redhat.com; broo...@kernel.org;
> j...@nvidia.com; gre...@linuxfoundation.org; k...@kernel.org; Williams,
> Dan J ; Saleem, Shiraz
> ; da...@davemloft.net; Patil, Kiran
>
> Subject: Re
nux.intel.com;
> fred...@linux.intel.com; linux-r...@vger.kernel.org;
> dledf...@redhat.com; broo...@kernel.org; j...@nvidia.com;
> gre...@linuxfoundation.org; k...@kernel.org; Williams, Dan J
> ; Saleem, Shiraz ;
> da...@davemloft.net; Patil, Kiran
> Subject: Re: [PATCH v2 1/6] Add ancillary bus
> From: Leon Romanovsky
> Sent: Thursday, October 8, 2020 12:56 AM
>
> > > This API is partially obscures low level driver-core code and needs
> > > to provide clear and proper abstractions without need to remember
> > > about put_device. There is already _add() interface why don't you do
> > >
an
>
> Subject: Re: [PATCH v2 1/6] Add ancillary bus support
>
> On Wed, Oct 7, 2020 at 6:37 AM Leon Romanovsky
> wrote:
> >
> > On Wed, Oct 07, 2020 at 01:09:55PM +0000, Saleem, Shiraz wrote:
> > > > Subject: Re: [PATCH v2 1/6] Add ancillary bus su
ierre-Louis
> Bossart ; fred...@linux.intel.com;
> linux-r...@vger.kernel.org; dledf...@redhat.com; broo...@kernel.org;
> j...@nvidia.com; gre...@linuxfoundation.org; k...@kernel.org; Williams,
> Dan J ; Saleem, Shiraz
> ; da...@davemloft.net; Patil, Kiran
>
> Subject: RE: [PATCH v2 1/6] Add a
n J ; Saleem, Shiraz
> > ; da...@davemloft.net; Patil, Kiran
> >
> > Subject: Re: [PATCH v2 1/6] Add ancillary bus support
> >
> > On Tue, Oct 06, 2020 at 10:18:07AM -0500, Pierre-Louis Bossart wrote:
> > > Thanks for the review Leon.
> > >
> &g
On Wed, Oct 7, 2020 at 6:37 AM Leon Romanovsky wrote:
>
> On Wed, Oct 07, 2020 at 01:09:55PM +, Saleem, Shiraz wrote:
> > > Subject: Re: [PATCH v2 1/6] Add ancillary bus support
> > >
> > > On Tue, Oct 6, 2020 at 12:21 PM Leon Romanovsky wrote:
> > &g
linux.intel.com; fred...@linux.intel.com; linux-
> r...@vger.kernel.org; dledf...@redhat.com; broo...@kernel.org;
> j...@nvidia.com; gre...@linuxfoundation.org; k...@kernel.org; Williams,
> Dan J ; Saleem, Shiraz
> ; da...@davemloft.net; Patil, Kiran
>
> Subject: Re: [PATCH v2 1/6] Add ancillary b
On Wed, Oct 07, 2020 at 01:09:55PM +, Saleem, Shiraz wrote:
> > Subject: Re: [PATCH v2 1/6] Add ancillary bus support
> >
> > On Tue, Oct 6, 2020 at 12:21 PM Leon Romanovsky wrote:
> > >
> > > On Tue, Oct 06, 2020 at 05:41:00PM +, Saleem, Shiraz wrote:
> Subject: Re: [PATCH v2 1/6] Add ancillary bus support
>
> On Tue, Oct 6, 2020 at 12:21 PM Leon Romanovsky wrote:
> >
> > On Tue, Oct 06, 2020 at 05:41:00PM +, Saleem, Shiraz wrote:
> > > > Subject: Re: [PATCH v2 1/6] Add ancillary bus support
> > &g
On Tue, Oct 6, 2020 at 12:21 PM Leon Romanovsky wrote:
>
> On Tue, Oct 06, 2020 at 05:41:00PM +, Saleem, Shiraz wrote:
> > > Subject: Re: [PATCH v2 1/6] Add ancillary bus support
> > >
> > > On Tue, Oct 06, 2020 at 05:09:09PM +, Parav Pandit wrote:
> &
On Tue, Oct 06, 2020 at 05:41:00PM +, Saleem, Shiraz wrote:
> > Subject: Re: [PATCH v2 1/6] Add ancillary bus support
> >
> > On Tue, Oct 06, 2020 at 05:09:09PM +, Parav Pandit wrote:
> > >
> > > > From: Leon Romanovsky
> > > > Sent: T
On Tue, 2020-10-06 at 20:26 +0300, Leon Romanovsky wrote:
> On Tue, Oct 06, 2020 at 05:09:09PM +, Parav Pandit wrote:
> > > From: Leon Romanovsky
> > > Sent: Tuesday, October 6, 2020 10:33 PM
> > >
> > > On Tue, Oct 06, 2020 at 10:18:07AM -0500, Pierre-Louis Bossart
> > > wrote:
> > > > Thank
> Subject: Re: [PATCH v2 1/6] Add ancillary bus support
>
> On Tue, Oct 06, 2020 at 10:18:07AM -0500, Pierre-Louis Bossart wrote:
> > Thanks for the review Leon.
> >
> > > > Add support for the Ancillary Bus, ancillary_device and
> > > > ancillary_dr
> Subject: Re: [PATCH v2 1/6] Add ancillary bus support
>
> On Mon, Oct 05, 2020 at 11:24:41AM -0700, Dave Ertman wrote:
> > Add support for the Ancillary Bus, ancillary_device and ancillary_driver.
> > It enables drivers to create an ancillary_device and bind an
>
> Subject: Re: [PATCH v2 1/6] Add ancillary bus support
>
> On Tue, Oct 06, 2020 at 05:09:09PM +, Parav Pandit wrote:
> >
> > > From: Leon Romanovsky
> > > Sent: Tuesday, October 6, 2020 10:33 PM
> > >
> > > On Tue, Oct 06, 2020 at 10:18:07A
On Tue, Oct 06, 2020 at 05:09:09PM +, Parav Pandit wrote:
>
> > From: Leon Romanovsky
> > Sent: Tuesday, October 6, 2020 10:33 PM
> >
> > On Tue, Oct 06, 2020 at 10:18:07AM -0500, Pierre-Louis Bossart wrote:
> > > Thanks for the review Leon.
> > >
> > > > > Add support for the Ancillary Bus, a
On Mon, Oct 05, 2020 at 11:24:41AM -0700, Dave Ertman wrote:
> Add support for the Ancillary Bus, ancillary_device and ancillary_driver.
> It enables drivers to create an ancillary_device and bind an
> ancillary_driver to it.
>
> The bus supports probe/remove shutdown and suspend/resume callbacks.
> From: Leon Romanovsky
> Sent: Tuesday, October 6, 2020 10:33 PM
>
> On Tue, Oct 06, 2020 at 10:18:07AM -0500, Pierre-Louis Bossart wrote:
> > Thanks for the review Leon.
> >
> > > > Add support for the Ancillary Bus, ancillary_device and
> > > > ancillary_driver.
> > > > It enables drivers t
On Tue, Oct 06, 2020 at 10:18:07AM -0500, Pierre-Louis Bossart wrote:
> Thanks for the review Leon.
>
> > > Add support for the Ancillary Bus, ancillary_device and ancillary_driver.
> > > It enables drivers to create an ancillary_device and bind an
> > > ancillary_driver to it.
> >
> > I was under
Thanks for the review Leon.
Add support for the Ancillary Bus, ancillary_device and ancillary_driver.
It enables drivers to create an ancillary_device and bind an
ancillary_driver to it.
I was under impression that this name is going to be changed.
It's part of the opens stated in the cover
On Mon, Oct 05, 2020 at 11:24:41AM -0700, Dave Ertman wrote:
> Add support for the Ancillary Bus, ancillary_device and ancillary_driver.
> It enables drivers to create an ancillary_device and bind an
> ancillary_driver to it.
I was under impression that this name is going to be changed.
>
> The b
Add support for the Ancillary Bus, ancillary_device and ancillary_driver.
It enables drivers to create an ancillary_device and bind an
ancillary_driver to it.
The bus supports probe/remove shutdown and suspend/resume callbacks.
Each ancillary_device has a unique string based id; driver binds to
an
59 matches
Mail list logo
