Re: [PATCH v2 1/2] virtio-net: rephrase devconf fields description

2015-08-19 Thread Jason Wang
On 08/19/2015 07:54 PM, Victor Kaplansky wrote: > On Mon, Aug 17, 2015 at 10:43:46AM +0800, Jason Wang wrote: >> >> On 08/16/2015 09:42 PM, Victor Kaplansky wrote: >>> Clarify general description of the mac, status and >>> max_virtqueue_pairs fields. Specifically, the old description is >>> vague

Re: [PATCH v2 1/2] virtio-net: rephrase devconf fields description

2015-08-19 Thread Victor Kaplansky
On Mon, Aug 17, 2015 at 10:43:46AM +0800, Jason Wang wrote: > > > On 08/16/2015 09:42 PM, Victor Kaplansky wrote: > > Clarify general description of the mac, status and > > max_virtqueue_pairs fields. Specifically, the old description is > > vague about configuration layout and fields offsets whe

Re: [PATCH v2 1/2] virtio-net: rephrase devconf fields description

2015-08-16 Thread Jason Wang
On 08/16/2015 09:42 PM, Victor Kaplansky wrote: > Clarify general description of the mac, status and > max_virtqueue_pairs fields. Specifically, the old description is > vague about configuration layout and fields offsets when some of > the fields are non valid. > > Also clarify that validity of

[PATCH v2 1/2] virtio-net: rephrase devconf fields description

2015-08-16 Thread Victor Kaplansky
Clarify general description of the mac, status and max_virtqueue_pairs fields. Specifically, the old description is vague about configuration layout and fields offsets when some of the fields are non valid. Also clarify that validity of two status bits depends on two different feature flags. Sign