Re: Re: [PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value

2016-12-27 Thread David Dillow
On Sun, 2016-12-25 at 01:30 +0100, Thomas Preisner wrote: > Those spaces were actually left out purposely: The file in question > (typhoon.c) > is missing those spaces between the statements (if, for, while) and the > following opening bracket pretty much always (except 2-3 times) and we figured >

Re: Re: [PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread Thomas Preisner
Hello. On Sat, 2016-12-24 at 20:06 +0100, Sergei Shtylyov wrote: >Hello! > >On 12/24/2016 03:02 PM, Thomas Preisner wrote: > >> In a few cases the err-variable is not set to a negative error code if a >> function call fails and thus 0 is returned instead. >> It may be better to set err to the appr

Re: [PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread Sergei Shtylyov
Hello! On 12/24/2016 03:02 PM, Thomas Preisner wrote: In a few cases the err-variable is not set to a negative error code if a function call fails and thus 0 is returned instead. It may be better to set err to the appropriate negative error code before returning. Bugzilla: https://bugzilla.ker

[PATCH v2 1/2] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread Thomas Preisner
In a few cases the err-variable is not set to a negative error code if a function call fails and thus 0 is returned instead. It may be better to set err to the appropriate negative error code before returning. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188841 Reported-by: Pan Bian Sig