Re: [PATCH v2 02/12] net: ethernet: aquantia: Common functions and definitions

2017-01-06 Thread Lino Sanfilippo
Hi, On 06.01.2017 09:06, Alexander Loktionov wrote: + +#define TXT(_T_) #_T_ +#define TXTTXT(_T_) TXT(_T_) do you really need these (IMHO ugly) macros? AFAICS you only use them to build the driver version string. + +#define AQ_CFG_DRV_AUTHOR "aQuantia" +#define AQ_CFG_DRV_DESC"

[PATCH v2 02/12] net: ethernet: aquantia: Common functions and definitions

2017-01-06 Thread Alexander Loktionov
From: David VomLehn Add files containing the functions and definitions used in common in different functional areas. Signed-off-by: Alexander Loktionov Signed-off-by: Dmitrii Tarakanov Signed-off-by: Pavel Belous Signed-off-by: David M. VomLehn --- drivers/net/ethernet/aquantia/aq_cfg.h