Re: [PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-11 Thread David Miller
From: Allen Date: Fri, 11 Sep 2020 15:30:41 +0530 >> Just add a backpointer to the netdev from the netdev_priv() if you >> absolutely have too. >> > > How does this look? Looks good.

Re: [PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-11 Thread Allen
> >> > > >> > > >> > -static void ace_tasklet(unsigned long arg) > >> > +static void ace_tasklet(struct tasklet_struct *t) > >> > { > >> > - struct net_device *dev = (struct net_device *) arg; > >> > - struct ace_private *ap = netdev_priv(dev); > >> > + struct ace_private *ap = from_ta

Re: [PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-10 Thread Allen
> > >> > >> > @@ -1562,10 +1562,11 @@ static void ace_watchdog(struct net_device > >> > *data, unsigned int txqueue) > >> > } > >> > > >> > > >> > -static void ace_tasklet(unsigned long arg) > >> > +static void ace_tasklet(struct tasklet_struct *t) > >> > { > >> > - struct net_device *dev =

Re: [PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-09 Thread David Miller
From: Allen Date: Thu, 10 Sep 2020 00:06:47 +0530 >> >> > @@ -1562,10 +1562,11 @@ static void ace_watchdog(struct net_device *data, >> > unsigned int txqueue) >> > } >> > >> > >> > -static void ace_tasklet(unsigned long arg) >> > +static void ace_tasklet(struct tasklet_struct *t) >> > { >> > -

Re: [PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-09 Thread Allen
> > > @@ -1562,10 +1562,11 @@ static void ace_watchdog(struct net_device *data, > > unsigned int txqueue) > > } > > > > > > -static void ace_tasklet(unsigned long arg) > > +static void ace_tasklet(struct tasklet_struct *t) > > { > > - struct net_device *dev = (struct net_device *) arg; > > -

Re: [PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-09 Thread David Miller
From: Allen Pais Date: Wed, 9 Sep 2020 14:14:51 +0530 > @@ -1562,10 +1562,11 @@ static void ace_watchdog(struct net_device *data, > unsigned int txqueue) > } > > > -static void ace_tasklet(unsigned long arg) > +static void ace_tasklet(struct tasklet_struct *t) > { > - struct net_devic

[PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-09 Thread Allen Pais
In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/net/ethernet/alteon/acenic