Re: [PATCH v2 01/11] net: phy: Add rockchip phy driver support

2017-07-28 Thread David.Wu
Hi Florian, 在 2017/7/28 0:51, Florian Fainelli 写道: +} + +static int rockchip_internal_phy_config_init(struct phy_device *phydev) +{ + int val; + + /* +* The auto MIDX has linked problem on some board, +* workround to disable auto MDIX. +*/ If this a board-spe

Re: [PATCH v2 01/11] net: phy: Add rockchip phy driver support

2017-07-28 Thread David.Wu
Hi Andrew, 在 2017/7/27 21:38, Andrew Lunn 写道: + /* +* If mode switch happens from 10BT to 100BT, all DSP/AFE +* registers are set to default values. So any AFE/DSP +* registers have to be re-initialized in this case. +*/ Hi David Are they also lost on sus

Re: [PATCH v2 01/11] net: phy: Add rockchip phy driver support

2017-07-27 Thread Florian Fainelli
On 07/27/2017 05:55 AM, David Wu wrote: > Support internal ephy currently. > > Signed-off-by: David Wu > --- > changes in v2: > - Alphabetic order for Kconfig and Makefile. > - Add analog register init. > - Disable auto-mdix for workround. > - Rename config > > drivers/net/phy/Kconfig|

Re: [PATCH v2 01/11] net: phy: Add rockchip phy driver support

2017-07-27 Thread Andrew Lunn
> + /* > + * If mode switch happens from 10BT to 100BT, all DSP/AFE > + * registers are set to default values. So any AFE/DSP > + * registers have to be re-initialized in this case. > + */ Hi David Are they also lost on suspend and resume? Andrew

[PATCH v2 01/11] net: phy: Add rockchip phy driver support

2017-07-27 Thread David Wu
Support internal ephy currently. Signed-off-by: David Wu --- changes in v2: - Alphabetic order for Kconfig and Makefile. - Add analog register init. - Disable auto-mdix for workround. - Rename config drivers/net/phy/Kconfig| 5 ++ drivers/net/phy/Makefile | 1 + drivers/net/phy/ro