Re: [PATCH v2 00/16] Remove uninitialized_var() macro

2020-06-22 Thread Sedat Dilek
On Sat, Jun 20, 2020 at 5:57 PM Kees Cook wrote: > > On Sat, Jun 20, 2020 at 09:03:34AM +0200, Sedat Dilek wrote: > > On Sat, Jun 20, 2020 at 5:30 AM Kees Cook wrote: > > > > > > v2: > > > - more special-cased fixes > > > - add reviews > > > v1: > > > https://lore.kernel.org/lkml/20200603233203.

Re: [PATCH v2 00/16] Remove uninitialized_var() macro

2020-06-20 Thread Kees Cook
On Sat, Jun 20, 2020 at 09:03:34AM +0200, Sedat Dilek wrote: > On Sat, Jun 20, 2020 at 5:30 AM Kees Cook wrote: > > > > v2: > > - more special-cased fixes > > - add reviews > > v1: > > https://lore.kernel.org/lkml/20200603233203.1695403-1-keesc...@chromium.org > > > > Using uninitialized_var() is

Re: [PATCH v2 00/16] Remove uninitialized_var() macro

2020-06-20 Thread Sedat Dilek
On Sat, Jun 20, 2020 at 5:30 AM Kees Cook wrote: > > v2: > - more special-cased fixes > - add reviews > v1: > https://lore.kernel.org/lkml/20200603233203.1695403-1-keesc...@chromium.org > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppres

[PATCH v2 00/16] Remove uninitialized_var() macro

2020-06-19 Thread Kees Cook
v2: - more special-cased fixes - add reviews v1: https://lore.kernel.org/lkml/20200603233203.1695403-1-keesc...@chromium.org Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the com