Re: [PATCH v2 0/4] Check size of packets before sending

2018-01-29 Thread David Miller
From: Daniel Axtens Date: Mon, 29 Jan 2018 14:20:58 +1100 > OK, so how about: > > - first, a series that introduces skb_gso_validate_mac_len and uses it >in bnx2x. This should be backportable without difficulty. > > - then, a series that wires skb_gso_validate_mac_len into the core - >

Re: [PATCH v2 0/4] Check size of packets before sending

2018-01-28 Thread Daniel Axtens
Eric Dumazet writes: > On Fri, 2018-01-26 at 00:44 +1100, Daniel Axtens wrote: >> Hi Eric, >> >> > May I ask which tree are you targeting ? >> > >> > ( Documentation/networking/netdev-FAQ.txt ) >> >> I have been targeting net-next, but I haven't pulled for about two >> weeks. I will rebase and

Re: [PATCH v2 0/4] Check size of packets before sending

2018-01-25 Thread Marcelo Ricardo Leitner
On Thu, Jan 25, 2018 at 03:31:05PM +1100, Daniel Axtens wrote: > There are a few ways we can send packets that are too large to a > network driver. > > When non-GSO packets are forwarded, we validate their size, based on > the MTU of the destination device. However, when GSO packets are > forwarde

Re: [PATCH v2 0/4] Check size of packets before sending

2018-01-25 Thread Eric Dumazet
On Fri, 2018-01-26 at 00:44 +1100, Daniel Axtens wrote: > Hi Eric, > > > May I ask which tree are you targeting ? > > > > ( Documentation/networking/netdev-FAQ.txt ) > > I have been targeting net-next, but I haven't pulled for about two > weeks. I will rebase and if there are conflicts I will re

Re: [PATCH v2 0/4] Check size of packets before sending

2018-01-25 Thread Daniel Axtens
Hi Eric, > May I ask which tree are you targeting ? > > ( Documentation/networking/netdev-FAQ.txt ) I have been targeting net-next, but I haven't pulled for about two weeks. I will rebase and if there are conflicts I will resend early next week. > Anything touching GSO is very risky and should t

Re: [PATCH v2 0/4] Check size of packets before sending

2018-01-25 Thread Eric Dumazet
On Thu, 2018-01-25 at 15:31 +1100, Daniel Axtens wrote: > There are a few ways we can send packets that are too large to a > network driver. > > When non-GSO packets are forwarded, we validate their size, based on > the MTU of the destination device. However, when GSO packets are > forwarded, we d

[PATCH v2 0/4] Check size of packets before sending

2018-01-24 Thread Daniel Axtens
There are a few ways we can send packets that are too large to a network driver. When non-GSO packets are forwarded, we validate their size, based on the MTU of the destination device. However, when GSO packets are forwarded, we do not validate their size. We implicitly assume that when they are s