Re: [PATCH v2 0/2] pegasus: correct buffer sizes

2016-04-27 Thread Johannes Berg
On Wed, 2016-04-27 at 16:26 +, David Laight wrote: > From: Johannes Berg > > > > Sent: 27 April 2016 10:44 > > On Wed, 2016-04-27 at 12:33 +0300, Petko Manolov wrote: > > > > > > > > > Your guess turned out to be not so wild.;)All Pegasus devices are > > > configured (by the driver) to appen

RE: [PATCH v2 0/2] pegasus: correct buffer sizes

2016-04-27 Thread David Laight
From: Johannes Berg > Sent: 27 April 2016 10:44 > On Wed, 2016-04-27 at 12:33 +0300, Petko Manolov wrote: > > > > Your guess turned out to be not so wild.;)All Pegasus devices are > > configured (by the driver) to append CRC at the end of each RX > > packet.However, the driver reports packet length

Re: [PATCH v2 0/2] pegasus: correct buffer sizes

2016-04-27 Thread Johannes Berg
On Wed, 2016-04-27 at 12:33 +0300, Petko Manolov wrote: >  > Your guess turned out to be not so wild.  ;)  All Pegasus devices are > configured  (by the driver) to append CRC at the end of each RX > packet.  However, the driver reports packet length that does not > include it.   Interesting, then

Re: [PATCH v2 0/2] pegasus: correct buffer sizes

2016-04-27 Thread Johannes Berg
On Wed, 2016-04-27 at 10:35 +0300, Petko Manolov wrote: >  > Nearly all Pegasus devices may append the RX status to the end of the > received  packet.  It is the default setup for the driver.  The > actual ethernet packet is  4 bytes shorter.  Why and when 'pkt_len -= > 4' became 'pkt_len -= 8' is

[PATCH v2 0/2] pegasus: correct buffer sizes

2016-04-27 Thread Petko Manolov
As noticed by Lincoln Ramsay some old (usb 1.1) Pegasus based devices may actually return more bytes than the specified in the datasheet amount. That would not be a problem if the allocated space for the SKB was equal to the parameter passed to usb_fill_bulk_urb(). Some poor bugger (i reall