Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-13 Thread Hanjun Guo
On 08/12/2015 11:36 PM, David Daney wrote: On 08/12/2015 08:23 AM, Catalin Marinas wrote: On Tue, Aug 11, 2015 at 01:04:55PM -0700, David Daney wrote: On 08/11/2015 11:49 AM, David Miller wrote: From: David Daney Date: Mon, 10 Aug 2015 17:58:35 -0700 Change from v1: Drop PHY binding part,

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-12 Thread David Daney
On 08/12/2015 08:23 AM, Catalin Marinas wrote: On Tue, Aug 11, 2015 at 01:04:55PM -0700, David Daney wrote: On 08/11/2015 11:49 AM, David Miller wrote: From: David Daney Date: Mon, 10 Aug 2015 17:58:35 -0700 Change from v1: Drop PHY binding part, use fwnode_property* APIs. The first patch

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-12 Thread Catalin Marinas
On Tue, Aug 11, 2015 at 01:04:55PM -0700, David Daney wrote: > On 08/11/2015 11:49 AM, David Miller wrote: > >From: David Daney > >Date: Mon, 10 Aug 2015 17:58:35 -0700 > > > >>Change from v1: Drop PHY binding part, use fwnode_property* APIs. > >> > >>The first patch (1/2) rearranges the existing

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-11 Thread David Miller
From: Robert Richter Date: Tue, 11 Aug 2015 22:12:37 +0200 > On 11.08.15 13:04:55, David Daney wrote: >> >In the future it might be better structured to try and get the OF >> >node, and if that fails then try and use the ACPI method to obtain >> >these values. >> >> Our current approach, as you

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-11 Thread David Miller
From: David Daney Date: Tue, 11 Aug 2015 13:04:55 -0700 > You seem to be recommending precedence for OF. It should be > consistent across all drivers/sub-systems, so do you really think > that OF before ACPI is the way to go? I just think it's more hackish to test acpi_disabled than to simply s

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-11 Thread Robert Richter
On 11.08.15 13:04:55, David Daney wrote: > >In the future it might be better structured to try and get the OF > >node, and if that fails then try and use the ACPI method to obtain > >these values. > > Our current approach, as you can see in the patch, is the opposite. If ACPI > is being used, pre

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-11 Thread David Daney
On 08/11/2015 11:49 AM, David Miller wrote: From: David Daney Date: Mon, 10 Aug 2015 17:58:35 -0700 Change from v1: Drop PHY binding part, use fwnode_property* APIs. The first patch (1/2) rearranges the existing code a little with no functional change to get ready for the second. The second

Re: [PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-11 Thread David Miller
From: David Daney Date: Mon, 10 Aug 2015 17:58:35 -0700 > Change from v1: Drop PHY binding part, use fwnode_property* APIs. > > The first patch (1/2) rearranges the existing code a little with no > functional change to get ready for the second. The second (2/2) does > the actual work of adding

[PATCH v2 0/2] net: thunder: Add ACPI support.

2015-08-10 Thread David Daney
From: David Daney Change from v1: Drop PHY binding part, use fwnode_property* APIs. The first patch (1/2) rearranges the existing code a little with no functional change to get ready for the second. The second (2/2) does the actual work of adding support to extract the needed information from