Re: [PATCH v2] tipc: fix shutdown() of connectionless socket

2020-09-03 Thread Tetsuo Handa
Hello, Parthasarathy. I have a question regarding commit 6f00089c7372ba97 ("tipc: remove SS_DISCONNECTING state"). That commit added sk->sk_shutdown = SEND_SHUTDOWN; into tipc_shutdown(). What is the reason you chose SEND_SHUTDOWN despite how == SHUT_RDWR ? Since Wouter commented that

Re: [PATCH v2] tipc: fix shutdown() of connectionless socket

2020-09-02 Thread David Miller
From: Tetsuo Handa Date: Wed, 2 Sep 2020 22:44:16 +0900 > syzbot is reporting hung task at nbd_ioctl() [1], for there are two > problems regarding TIPC's connectionless socket's shutdown() operation. ... > One problem is that wait_for_completion() from flush_workqueue() from > nbd_start_device_i

[PATCH v2] tipc: fix shutdown() of connectionless socket

2020-09-02 Thread Tetsuo Handa
syzbot is reporting hung task at nbd_ioctl() [1], for there are two problems regarding TIPC's connectionless socket's shutdown() operation. -- #include #include #include #include #include int main(int argc, char *argv[]) { const int fd = open("/dev/nbd0", 3); alarm(5)