Re: [PATCH v2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-17 Thread Neal Cardwell
On Tue, Sep 17, 2019 at 1:22 PM Eric Dumazet wrote: > > Tue, Sep 17, 2019 at 10:13 AM Jason Baron wrote: > > > > > > Hi, > > > > I was interested in adding a field to tcp_info around the TFO state of a > > socket. So for the server side it would indicate if TFO was used to > > create the socket

Re: [PATCH v2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-17 Thread Eric Dumazet
Tue, Sep 17, 2019 at 10:13 AM Jason Baron wrote: > > > Hi, > > I was interested in adding a field to tcp_info around the TFO state of a > socket. So for the server side it would indicate if TFO was used to > create the socket and on the client side it would report whether TFO > worked and if not

Re: [PATCH v2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-17 Thread Jason Baron
On 9/10/19 4:38 PM, Eric Dumazet wrote: > On Tue, Sep 10, 2019 at 10:11 PM Thomas Higdon wrote: >> >> > ... >> Because an additional 32-bit member in struct tcp_info would cause >> a hole on 64-bit systems, we reserve a struct member '_reserved'. > ... >> diff --git a/include/uapi/linux/tcp.h b

Re: [PATCH v2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-10 Thread Neal Cardwell
On Tue, Sep 10, 2019 at 4:39 PM Eric Dumazet wrote: > > On Tue, Sep 10, 2019 at 10:11 PM Thomas Higdon wrote: > > > > > ... > > Because an additional 32-bit member in struct tcp_info would cause > > a hole on 64-bit systems, we reserve a struct member '_reserved'. > ... > > diff --git a/include/u

Re: [PATCH v2] tcp: Add TCP_INFO counter for packets received out-of-order

2019-09-10 Thread Eric Dumazet
On Tue, Sep 10, 2019 at 10:11 PM Thomas Higdon wrote: > > ... > Because an additional 32-bit member in struct tcp_info would cause > a hole on 64-bit systems, we reserve a struct member '_reserved'. ... > diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h > index b3564f85a762..990a5b