Re: [PATCH v2] smc: return booleans instead of integers

2018-01-23 Thread Ursula Braun
On 01/23/2018 01:31 AM, Joe Perches wrote: > On Mon, 2018-01-22 at 12:58 +0100, Ursula Braun wrote: >> >> On 01/19/2018 09:54 PM, Gustavo A. R. Silva wrote: >>> Return statements in functions returning bool should use >>> true/false instead of 1/0. >>> >>> This issue was detected with the help of

Re: [PATCH v2] smc: return booleans instead of integers

2018-01-22 Thread Joe Perches
On Mon, 2018-01-22 at 12:58 +0100, Ursula Braun wrote: > > On 01/19/2018 09:54 PM, Gustavo A. R. Silva wrote: > > Return statements in functions returning bool should use > > true/false instead of 1/0. > > > > This issue was detected with the help of Coccinelle. > > > > Signed-off-by: Gustavo A.

Re: [PATCH v2] smc: return booleans instead of integers

2018-01-22 Thread Gustavo A. R. Silva
Quoting Ursula Braun : [...] Thanks, Gustavo. I have added the patch to our local repository. It will be part of one of my next patch sets to be sent to Dave Miller. Thanks, Ursula :) -- Gustavo

Re: [PATCH v2] smc: return booleans instead of integers

2018-01-22 Thread Ursula Braun
On 01/19/2018 09:54 PM, Gustavo A. R. Silva wrote: > Return statements in functions returning bool should use > true/false instead of 1/0. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > --- > Changes in v2: > - Fix function using_ipsec as sug

[PATCH v2] smc: return booleans instead of integers

2018-01-19 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true/false instead of 1/0. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Fix function using_ipsec as suggested by Ursula Braun. - Update subject line. net/smc/smc.h | 4 ++-