Re: [PATCH v2] rtnetlink: fix data overflow in rtnl_calcit()

2020-10-20 Thread Jakub Kicinski
On Tue, 20 Oct 2020 13:51:15 +0800 zhudi wrote: > @@ -3735,7 +3735,7 @@ static u16 rtnl_calcit(struct sk_buff *skb, struct > nlmsghdr *nlh) >*/ > rcu_read_lock(); > for_each_netdev_rcu(net, dev) { > - min_ifinfo_dump_size = max_t(u16, min_ifinfo_dump_size, > +

[PATCH v2] rtnetlink: fix data overflow in rtnl_calcit()

2020-10-19 Thread zhudi
"ip addr show" command execute error when we have a physical network card with a large number of VFs The return value of if_nlmsg_size() in rtnl_calcit() will exceed range of u16 data type when any network cards has a larger number of VFs. rtnl_vfinfo_size() will significant increase needed dump s