Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

2015-12-11 Thread Corinna Vinschen
On Dec 11 01:06, Francois Romieu wrote: > Corinna Vinschen : > [...] > > It's still a bit weird. On the machines I tested this on, if I disable > > LanWake and shutdown the machine, I can send, e.g., MagicPackets as much > > as I like, the machined don't come up. Isn't it a bit misleading then >

Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

2015-12-10 Thread Francois Romieu
Corinna Vinschen : [...] > It's still a bit weird. On the machines I tested this on, if I disable > LanWake and shutdown the machine, I can send, e.g., MagicPackets as much > as I like, the machined don't come up. Isn't it a bit misleading then > if ethtool reports that some WoL method is enable

Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

2015-12-10 Thread Corinna Vinschen
On Dec 10 21:40, Francois Romieu wrote: > Corinna Vinschen : > [...] > > I could do this (after I could lay my hands on such a board, that is), > > but I'm not convinced that this makes a lot of sense for two reasons. > > Ok, let's get this change applied. Whatever happens should not be > hard to

Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

2015-12-10 Thread Francois Romieu
Corinna Vinschen : [...] > I could do this (after I could lay my hands on such a board, that is), > but I'm not convinced that this makes a lot of sense for two reasons. Ok, let's get this change applied. Whatever happens should not be hard to manage (I'm thinking about other boards or BIOSes rel

Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

2015-12-10 Thread Corinna Vinschen
On Dec 9 23:43, Francois Romieu wrote: > Corinna Vinschen : > [...] > > This patch is supposed to fix this behaviour. If LanWake is 0, the > > function now returns 0. Thus ethtool correctly reports "Wake-on: d". > > Can you turn it into a DMI controlled one (something like > drivers/net/ethern

Re: [PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

2015-12-09 Thread Francois Romieu
Corinna Vinschen : [...] > This patch is supposed to fix this behaviour. If LanWake is 0, the > function now returns 0. Thus ethtool correctly reports "Wake-on: d". Can you turn it into a DMI controlled one (something like drivers/net/ethernet/marvell/skge.c use of dmi_check_system) in order to

[PATCH v2] r8169: Don't claim WoL works if LanWake flag is not set

2015-12-09 Thread Corinna Vinschen
[v2 adds missing text to the patch comment] The __rtl8169_get_wol function returns the state of the various WoL method bits (MagicPaket, Unicast, etc.). While the PMEnable bit is tested at entry, the function doesn't check the LanWake flag. Even if any one of the WoL bits is set, WoL is deactiva