Re: [PATCH v2] ptp: mark symbols static where possible

2020-09-18 Thread David Miller
From: Herrington Date: Fri, 18 Sep 2020 14:10:13 +0800 > +void pch_ch_control_write(struct pci_dev *pdev, u32 val); > void pch_ch_control_write(struct pci_dev *pdev, u32 val) Prototypes belong in a header file not in the C file where they are defined. If these functions are accessed in other f

Re: [PATCH v2] ptp: mark symbols static where possible

2020-09-18 Thread Jakub Kicinski
On Fri, 18 Sep 2020 14:10:13 +0800 Herrington wrote: > We get 1 warning when building kernel with W=1: > drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for > ‘pch_ch_control_read’ [-Wmissing-prototypes] > u32 pch_ch_control_read(struct pci_dev *pdev) > drivers/ptp/ptp_pch.c:193:6: wa

[PATCH v2] ptp: mark symbols static where possible

2020-09-17 Thread Herrington
We get 1 warning when building kernel with W=1: drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for ‘pch_ch_control_read’ [-Wmissing-prototypes] u32 pch_ch_control_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:193:6: warning: no previous prototype for ‘pch_ch_control_write’ [-Wmis

[PATCH] [PATCH v2]ptp: mark symbols static where possible

2020-09-17 Thread Herrington
We get 1 warning when building kernel with W=1: drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for ‘pch_ch_control_read’ [-Wmissing-prototypes] u32 pch_ch_control_read(struct pci_dev *pdev) drivers/ptp/ptp_pch.c:193:6: warning: no previous prototype for ‘pch_ch_control_write’ [-Wmis