Re: [PATCH v2] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-08 Thread Kevin Hao
On Fri, May 08, 2020 at 05:38:33PM -0700, Jakub Kicinski wrote: > On Fri, 8 May 2020 19:49:53 +0800 Kevin Hao wrote: > > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > > index f1d2dea90a8c..612d33207326 100644

Re: [PATCH v2] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-08 Thread Jakub Kicinski
On Fri, 8 May 2020 19:49:53 +0800 Kevin Hao wrote: > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > index f1d2dea90a8c..612d33207326 100644 > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > +++

[PATCH v2] octeontx2-pf: Use the napi_alloc_frag() to alloc the pool buffers

2020-05-08 Thread Kevin Hao
In the current codes, the octeontx2 uses its own method to allocate the pool buffers, but there are some issues in this implementation. 1. We have to run the otx2_get_page() for each allocation cycle and this is pretty error prone. As I can see there is no invocation of the otx2_get_page() in