Re: [PATCH v2] net: use bulk free in kfree_skb_list

2019-03-25 Thread Jesper Dangaard Brouer
On Mon, 25 Mar 2019 10:35:35 +0100 Felix Fietkau wrote: > On 2019-03-25 10:31, Eric Dumazet wrote: > > On 03/25/2019 02:09 AM, Felix Fietkau wrote: > >> On 2019-03-25 09:51, Eric Dumazet wrote: > >>> On 03/24/2019 09:56 AM, Felix Fietkau wrote: > > Since we're freeing multiple skbs

Re: [PATCH v2] net: use bulk free in kfree_skb_list

2019-03-25 Thread Felix Fietkau
On 2019-03-25 10:31, Eric Dumazet wrote: > > > On 03/25/2019 02:09 AM, Felix Fietkau wrote: >> On 2019-03-25 09:51, Eric Dumazet wrote: >>> >>> >>> On 03/24/2019 09:56 AM, Felix Fietkau wrote: Since we're freeing multiple skbs, we might as well use bulk free to save a few cycles. Use th

Re: [PATCH v2] net: use bulk free in kfree_skb_list

2019-03-25 Thread Eric Dumazet
On 03/25/2019 02:09 AM, Felix Fietkau wrote: > On 2019-03-25 09:51, Eric Dumazet wrote: >> >> >> On 03/24/2019 09:56 AM, Felix Fietkau wrote: >>> Since we're freeing multiple skbs, we might as well use bulk free to save a >>> few cycles. Use the same conditions for bulk free as in napi_consume_s

Re: [PATCH v2] net: use bulk free in kfree_skb_list

2019-03-25 Thread Felix Fietkau
On 2019-03-25 09:51, Eric Dumazet wrote: > > > On 03/24/2019 09:56 AM, Felix Fietkau wrote: >> Since we're freeing multiple skbs, we might as well use bulk free to save a >> few cycles. Use the same conditions for bulk free as in napi_consume_skb. >> > > I do not believe kfree_skb_list() is use

Re: [PATCH v2] net: use bulk free in kfree_skb_list

2019-03-25 Thread Paolo Abeni
Hi, On Sun, 2019-03-24 at 17:56 +0100, Felix Fietkau wrote: > Since we're freeing multiple skbs, we might as well use bulk free to save a > few cycles. Use the same conditions for bulk free as in napi_consume_skb. > > Signed-off-by: Felix Fietkau > --- > v2: call kmem_cache_free_bulk once the sk

Re: [PATCH v2] net: use bulk free in kfree_skb_list

2019-03-25 Thread Eric Dumazet
On 03/24/2019 09:56 AM, Felix Fietkau wrote: > Since we're freeing multiple skbs, we might as well use bulk free to save a > few cycles. Use the same conditions for bulk free as in napi_consume_skb. > I do not believe kfree_skb_list() is used in the fast path, so do we really need to make it s

Re: [PATCH v2] net: use bulk free in kfree_skb_list

2019-03-24 Thread Jesper Dangaard Brouer
On Sun, 24 Mar 2019 17:56:44 +0100 Felix Fietkau wrote: > Since we're freeing multiple skbs, we might as well use bulk free to save a > few cycles. Use the same conditions for bulk free as in napi_consume_skb. > > Signed-off-by: Felix Fietkau > --- > v2: call kmem_cache_free_bulk once the skb a

[PATCH v2] net: use bulk free in kfree_skb_list

2019-03-24 Thread Felix Fietkau
Since we're freeing multiple skbs, we might as well use bulk free to save a few cycles. Use the same conditions for bulk free as in napi_consume_skb. Signed-off-by: Felix Fietkau --- v2: call kmem_cache_free_bulk once the skb array is full instead of falling back to kfree_skb net/core/skbuff