Re: [PATCH v2] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware

2019-10-22 Thread Oliver Hartkopp
On 22/10/2019 19.28, Eric Dumazet wrote On 10/22/19 9:42 AM, Stephen Hemminger wrote: Why not fix fq_codel to return the same errors as other qdisc? I believe the same problem would happen with any qdisc not doing tail drops. Do we really want to enforce all qdisc to have a common drop st

Re: [PATCH v2] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware

2019-10-22 Thread Eric Dumazet
On 10/22/19 9:42 AM, Stephen Hemminger wrote: > Why not fix fq_codel to return the same errors as other qdisc? > I believe the same problem would happen with any qdisc not doing tail drops. Do we really want to enforce all qdisc to have a common drop strategy ? For example, FQ could impleme

Re: [PATCH v2] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware

2019-10-22 Thread Marc Kleine-Budde
On 10/22/19 6:42 PM, Stephen Hemminger wrote: > On Tue, 22 Oct 2019 16:53:44 +0200 > Marc Kleine-Budde wrote: > >> On 10/22/19 3:23 PM, Vincent Prince wrote: >>> Signed-off-by: Vincent Prince >> >> please include a patch description. I.e. this one: >> >> >8>8>8>

Re: [PATCH v2] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware

2019-10-22 Thread Stephen Hemminger
On Tue, 22 Oct 2019 16:53:44 +0200 Marc Kleine-Budde wrote: > On 10/22/19 3:23 PM, Vincent Prince wrote: > > Signed-off-by: Vincent Prince > > please include a patch description. I.e. this one: > > >8>8>8>8>8>8>8 > > There is

Re: [PATCH v2] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware

2019-10-22 Thread Marc Kleine-Budde
On 10/22/19 4:53 PM, Marc Kleine-Budde wrote: > On 10/22/19 3:23 PM, Vincent Prince wrote: >> Signed-off-by: Vincent Prince > > please include a patch description. I.e. this one: > > >8>8>8>8>8>8>8 > There is networking hardware tha

Re: [PATCH v2] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware

2019-10-22 Thread Marc Kleine-Budde
On 10/22/19 3:23 PM, Vincent Prince wrote: > Signed-off-by: Vincent Prince please include a patch description. I.e. this one: >8>8>8>8>8>8>8 There is networking hardware that isn't based on Ethernet for layers 1 and 2. For example

[PATCH v2] net: sch_generic: Use pfifo_fast as fallback scheduler for CAN hardware

2019-10-22 Thread Vincent Prince
Signed-off-by: Vincent Prince --- Changes in v2: - reformat patch net/sched/sch_generic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 77b289d..dfb2982 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -1008,6