Re: [PATCH v2] net: ns83820: drop pointless static qualifier in ns83820_probe_phy()

2019-02-19 Thread maowenan
On 2019/2/19 16:31, Julia Lawall wrote: > > > On Tue, 19 Feb 2019, Mao Wenan wrote: > >> There is no need to have the 'int first' static >> since new value always be assigned before use it. >> >> This patch cleans up the codes in ns83820_probe_phy() as well. > > As mentioned previously, ther

Re: [PATCH v2] net: ns83820: drop pointless static qualifier in ns83820_probe_phy()

2019-02-19 Thread Julia Lawall
On Tue, 19 Feb 2019, Mao Wenan wrote: > There is no need to have the 'int first' static > since new value always be assigned before use it. > > This patch cleans up the codes in ns83820_probe_phy() as well. As mentioned previously, there is no use of first in the function at all, other than se

[PATCH v2] net: ns83820: drop pointless static qualifier in ns83820_probe_phy()

2019-02-19 Thread Mao Wenan
There is no need to have the 'int first' static since new value always be assigned before use it. This patch cleans up the codes in ns83820_probe_phy() as well. Signed-off-by: Mao Wenan --- v1->v2: delete unused codes. drivers/net/ethernet/natsemi/ns83820.c | 17 + 1 file chang