Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 01:52:50PM +0200, Sascha Hauer wrote: > On Fri, Jun 12, 2020 at 12:30:31PM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, Jun 12, 2020 at 12:22:13PM +0100, Russell King - ARM Linux admin > > wrote: > > > On Fri, Jun 12, 2020 at 11:42:08AM +0100, Russell King -

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 02:06:04PM +0200, Sascha Hauer wrote: > And here is the same patch which applies on master and the net tree. > It works as expected on my Armada XP in 2.5Gbps mode. Provided you are > happy with the patch I can send it as a formal patch on monday if by > then you haven't don

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Sascha Hauer
On Fri, Jun 12, 2020 at 11:18:20AM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 11:01:15AM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, Jun 12, 2020 at 09:47:10AM +0100, Russell King - ARM Linux admin > > wrote: > > > On Fri, Jun 12, 2020 at 10:38:47AM +020

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Sascha Hauer
On Fri, Jun 12, 2020 at 12:30:31PM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 12:22:13PM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, Jun 12, 2020 at 11:42:08AM +0100, Russell King - ARM Linux admin > > wrote: > > > With the obvious mistakes fixed (extran

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 12:22:13PM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 11:42:08AM +0100, Russell King - ARM Linux admin > wrote: > > With the obvious mistakes fixed (extraneous 'i' and lack of default > > case), it seems to still work on Armada 388 Clearfog Pro w

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 11:42:08AM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 11:18:20AM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, Jun 12, 2020 at 11:01:15AM +0100, Russell King - ARM Linux admin > > wrote: > > > On Fri, Jun 12, 2020 at 09:47:10AM +010

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 11:18:20AM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 11:01:15AM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, Jun 12, 2020 at 09:47:10AM +0100, Russell King - ARM Linux admin > > wrote: > > > On Fri, Jun 12, 2020 at 10:38:47AM +020

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 11:01:15AM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 09:47:10AM +0100, Russell King - ARM Linux admin > wrote: > > On Fri, Jun 12, 2020 at 10:38:47AM +0200, Sascha Hauer wrote: > > > The Marvell MVNETA Ethernet controller supports a 2.5Gbps SGMI

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Sascha Hauer
On Fri, Jun 12, 2020 at 09:47:10AM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 10:38:47AM +0200, Sascha Hauer wrote: > > The Marvell MVNETA Ethernet controller supports a 2.5Gbps SGMII mode > > called DRSGMII. Depending on the Port MAC Control Register0 PortType > > setti

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 09:47:10AM +0100, Russell King - ARM Linux admin wrote: > On Fri, Jun 12, 2020 at 10:38:47AM +0200, Sascha Hauer wrote: > > The Marvell MVNETA Ethernet controller supports a 2.5Gbps SGMII mode > > called DRSGMII. Depending on the Port MAC Control Register0 PortType > > setti

Re: [PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Russell King - ARM Linux admin
On Fri, Jun 12, 2020 at 10:38:47AM +0200, Sascha Hauer wrote: > The Marvell MVNETA Ethernet controller supports a 2.5Gbps SGMII mode > called DRSGMII. Depending on the Port MAC Control Register0 PortType > setting this seems to be either an overclocked SGMII mode or 2500BaseX. > > This patch adds

[PATCH v2] net: mvneta: Fix Serdes configuration for 2.5Gbps modes

2020-06-12 Thread Sascha Hauer
The Marvell MVNETA Ethernet controller supports a 2.5Gbps SGMII mode called DRSGMII. Depending on the Port MAC Control Register0 PortType setting this seems to be either an overclocked SGMII mode or 2500BaseX. This patch adds the necessary Serdes Configuration setting for the 2.5Gbps modes. There