Re: [PATCH v2] net: mac802154: Fix general protection fault

2021-04-06 Thread Stefan Schmidt
Hello. On 05.04.21 13:50, Alexander Aring wrote: Hi, On Mon, 5 Apr 2021 at 01:45, Pavel Skripkin wrote: Hi! ... I forgot to check the patch with ./scripts/checkpatch.pl :( Dumb question: What is the meaning of it? This is for gerrit code review. This is required to push changes to

Re: [PATCH v2] net: mac802154: Fix general protection fault

2021-04-05 Thread Alexander Aring
Hi, On Mon, 5 Apr 2021 at 01:45, Pavel Skripkin wrote: > > Hi! > ... > > > > I forgot to check the patch with ./scripts/checkpatch.pl :( > > > Dumb question: What is the meaning of it? > > This is for gerrit code review. This is required to push changes to > gerrit public mirror. I'm using it to

Re: [PATCH v2] net: mac802154: Fix general protection fault

2021-04-04 Thread Pavel Skripkin
Hi! On Sun, 2021-04-04 at 20:43 -0400, Alexander Aring wrote: > Hi, > > On Thu, 4 Mar 2021 at 10:25, Pavel Skripkin > wrote: > > > > syzbot found general protection fault in crypto_destroy_tfm()[1]. > > It was caused by wrong clean up loop in llsec_key_alloc(). > > If one of the tfm array membe

Re: [PATCH v2] net: mac802154: Fix general protection fault

2021-04-04 Thread Alexander Aring
Hi, On Thu, 4 Mar 2021 at 10:25, Pavel Skripkin wrote: > > syzbot found general protection fault in crypto_destroy_tfm()[1]. > It was caused by wrong clean up loop in llsec_key_alloc(). > If one of the tfm array members is in IS_ERR() range it will > cause general protection fault in clean up fun

Re: [PATCH v2] net: mac802154: Fix general protection fault

2021-03-08 Thread Stefan Schmidt
Hello. On 04.03.21 16:21, Pavel Skripkin wrote: syzbot found general protection fault in crypto_destroy_tfm()[1]. It was caused by wrong clean up loop in llsec_key_alloc(). If one of the tfm array members is in IS_ERR() range it will cause general protection fault in clean up function [1]. Call

[PATCH v2] net: mac802154: Fix general protection fault

2021-03-04 Thread Pavel Skripkin
syzbot found general protection fault in crypto_destroy_tfm()[1]. It was caused by wrong clean up loop in llsec_key_alloc(). If one of the tfm array members is in IS_ERR() range it will cause general protection fault in clean up function [1]. Call Trace: crypto_free_aead include/crypto/aead.h:191