Re: [PATCH v2] net: korina: fix return value

2020-12-16 Thread Jakub Kicinski
On Wed, 16 Dec 2020 13:32:26 -0800 Florian Fainelli wrote: > On 12/16/20 12:43 PM, Jakub Kicinski wrote: > > On Mon, 14 Dec 2020 23:09:52 +0100 Vincent Stehlé wrote: > >> The ndo_start_xmit() method must not attempt to free the skb to transmit > >> when returning NETDEV_TX_BUSY. Therefore, make s

Re: [PATCH v2] net: korina: fix return value

2020-12-16 Thread Florian Fainelli
On 12/16/20 12:43 PM, Jakub Kicinski wrote: > On Mon, 14 Dec 2020 23:09:52 +0100 Vincent Stehlé wrote: >> The ndo_start_xmit() method must not attempt to free the skb to transmit >> when returning NETDEV_TX_BUSY. Therefore, make sure the >> korina_send_packet() function returns NETDEV_TX_OK when it

Re: [PATCH v2] net: korina: fix return value

2020-12-16 Thread Jakub Kicinski
On Mon, 14 Dec 2020 23:09:52 +0100 Vincent Stehlé wrote: > The ndo_start_xmit() method must not attempt to free the skb to transmit > when returning NETDEV_TX_BUSY. Therefore, make sure the > korina_send_packet() function returns NETDEV_TX_OK when it frees a packet. > > Fixes: ef11291bcd5f ("Add s

[PATCH v2] net: korina: fix return value

2020-12-14 Thread Vincent Stehlé
The ndo_start_xmit() method must not attempt to free the skb to transmit when returning NETDEV_TX_BUSY. Therefore, make sure the korina_send_packet() function returns NETDEV_TX_OK when it frees a packet. Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC") Suggested-by: Jakub