Re: [PATCH v2] net: ibm: emac: support RGMII-[RX|TX]ID phymode

2017-12-20 Thread Benjamin Herrenschmidt
On Wed, 2017-12-20 at 22:07 +0100, Christian Lamparter wrote: > > > will read this and say "Oh the function tests against these weird > > PHY_MODE_* aliases, but the helper function phy_interface_mode_is_rgmii() > > tests against PHY_INTERFACE_MODE_*, what is going on?" > > > > I hate to do this

Re: [PATCH v2] net: ibm: emac: support RGMII-[RX|TX]ID phymode

2017-12-20 Thread David Miller
From: Christian Lamparter Date: Wed, 20 Dec 2017 22:07:43 +0100 > Yeah, I can do that. no problem. > > Question is, should I also replace the rgmii_mode_name() with phy_modes() too? > > The only user of rgmii_mode_name() is this notice printk in rgmii_attach(): >

Re: [PATCH v2] net: ibm: emac: support RGMII-[RX|TX]ID phymode

2017-12-20 Thread Christian Lamparter
On Wednesday, December 20, 2017 3:10:46 PM CET David Miller wrote: > From: Christian Lamparter > Date: Wed, 20 Dec 2017 17:02:01 +0100 > > > diff --git a/drivers/net/ethernet/ibm/emac/emac.h > > b/drivers/net/ethernet/ibm/emac/emac.h > > index 5afcc27ceebb..8c6d2af7281b 100644 > > --- a/drivers/

Re: [PATCH v2] net: ibm: emac: support RGMII-[RX|TX]ID phymode

2017-12-20 Thread David Miller
From: Christian Lamparter Date: Wed, 20 Dec 2017 17:02:01 +0100 > diff --git a/drivers/net/ethernet/ibm/emac/emac.h > b/drivers/net/ethernet/ibm/emac/emac.h > index 5afcc27ceebb..8c6d2af7281b 100644 > --- a/drivers/net/ethernet/ibm/emac/emac.h > +++ b/drivers/net/ethernet/ibm/emac/emac.h > @@ -1

[PATCH v2] net: ibm: emac: support RGMII-[RX|TX]ID phymode

2017-12-20 Thread Christian Lamparter
The RGMII spec allows compliance for devices that implement an internal delay on TXC and/or RXC inside the transmitter. This patch adds the necessary RGMII_[RX|TX]ID mode code to handle such PHYs with the emac driver. Signed-off-by: Christian Lamparter --- v2: - utilize phy_interface_mode_is_rgm