Robert Jarzmik :
> Francois Romieu writes:
[...]
> > If you have some spare time, it would be nice to avoid db->irq_wake leak
> > on probe failure or driver removal.
> Sorry but not in this patch.
Of course. Different topic => different patch.
> I suppose the right patch would be to use devm_*(
Sergei Shtylyov writes:
>> Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse
>
>Fixes: tag here?
Heuh no. It doesn't fix this commit, it uses a feature brought by this commit.
>> +if (irq_get_trigger_type(dev->irq) == IRQF_TRIGGER_NONE)
>> dev_warn(db->de
Hello.
On 2/7/2016 1:11 AM, Robert Jarzmik wrote:
The dm9000 driver doesn't work in at least one device-tree
configuration, spitting an error message on irq resource :
[1.062495] dm9000 800.ethernet: insufficient resources
[1.068439] dm9000 800.ethernet: not found (-2).
[1.0
Francois Romieu writes:
> Robert Jarzmik :
> [...]
>> diff --git a/drivers/net/ethernet/davicom/dm9000.c
>> b/drivers/net/ethernet/davicom/dm9000.c
>> index cf94b72dbacd..2bae5c8c1f85 100644
>> --- a/drivers/net/ethernet/davicom/dm9000.c
>> +++ b/drivers/net/ethernet/davicom/dm9000.c
> [...]
>>
Robert Jarzmik :
[...]
> diff --git a/drivers/net/ethernet/davicom/dm9000.c
> b/drivers/net/ethernet/davicom/dm9000.c
> index cf94b72dbacd..2bae5c8c1f85 100644
> --- a/drivers/net/ethernet/davicom/dm9000.c
> +++ b/drivers/net/ethernet/davicom/dm9000.c
[...]
> @@ -1500,15 +1496,21 @@ dm9000_probe(
The dm9000 driver doesn't work in at least one device-tree
configuration, spitting an error message on irq resource :
[1.062495] dm9000 800.ethernet: insufficient resources
[1.068439] dm9000 800.ethernet: not found (-2).
[1.073451] dm9000: probe of 800.ethernet failed with e
