Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-08 Thread Andrew Lunn
> > Hi Jean > > > > I never said i was too specific to your board. There are other boards > > using different switches like this. This is where the commit message > > is so important. Without understanding Why? it is hard to point you in > > the right direction. > > > > So you setup is: > > > > SoC

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-07 Thread Andrew Lunn
On Mon, Dec 07, 2020 at 08:43:32PM +0100, Jean Pihet wrote: > Hi Andrew, > > On Tue, Dec 1, 2020 at 9:45 PM Andrew Lunn wrote: > > > > > Configure the host port of the switch to match the host interface > > > settings. This is useful when the switch is directly connected to the > > > host MAC int

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-07 Thread Jean Pihet
Hi Andrew, On Tue, Dec 1, 2020 at 9:45 PM Andrew Lunn wrote: > > > Configure the host port of the switch to match the host interface > > settings. This is useful when the switch is directly connected to the > > host MAC interface. > > Why do you need this when no other board does? Why is your boa

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-07 Thread Jean Pihet
Hi Vladimir, On Tue, Dec 1, 2020 at 8:48 PM Vladimir Oltean wrote: > > Hi Jean, > > On Tue, Dec 01, 2020 at 07:58:01PM +0100, Jean Pihet wrote: > > Hi Andrew, > > > > On Tue, Dec 1, 2020 at 7:41 PM Andrew Lunn wrote: > > > > > > On Tue, Dec 01, 2020 at 09:34:08AM +0100, Jean Pihet wrote: > > > >

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-01 Thread Andrew Lunn
> Configure the host port of the switch to match the host interface > settings. This is useful when the switch is directly connected to the > host MAC interface. Why do you need this when no other board does? Why is your board special? As i said before, i'm guessing your board has back to back PH

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-01 Thread Vladimir Oltean
Hi Jean, On Tue, Dec 01, 2020 at 07:58:01PM +0100, Jean Pihet wrote: > Hi Andrew, > > On Tue, Dec 1, 2020 at 7:41 PM Andrew Lunn wrote: > > > > On Tue, Dec 01, 2020 at 09:34:08AM +0100, Jean Pihet wrote: > > > Add support for RGMII in 100 and 1000 Mbps. > > > > > > Adjust the CPU port settings fr

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-01 Thread Jean Pihet
Hi Andrew, On Tue, Dec 1, 2020 at 7:41 PM Andrew Lunn wrote: > > On Tue, Dec 01, 2020 at 09:34:08AM +0100, Jean Pihet wrote: > > Add support for RGMII in 100 and 1000 Mbps. > > > > Adjust the CPU port settings from the host interface settings: interface > > MII type, speed, duplex. > > Hi Jean >

Re: [PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-01 Thread Andrew Lunn
On Tue, Dec 01, 2020 at 09:34:08AM +0100, Jean Pihet wrote: > Add support for RGMII in 100 and 1000 Mbps. > > Adjust the CPU port settings from the host interface settings: interface > MII type, speed, duplex. Hi Jean You have still not explained why this is needed. Why? is always the important

[PATCH v2] net: dsa: ksz8795: adjust CPU link to host interface

2020-12-01 Thread Jean Pihet
Add support for RGMII in 100 and 1000 Mbps. Adjust the CPU port settings from the host interface settings: interface MII type, speed, duplex. Signed-off-by: Jean Pihet --- drivers/net/dsa/microchip/ksz8795.c | 93 ++--- 1 file changed, 57 insertions(+), 36 deletions(-)