Re: [PATCH v2] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc

2020-08-26 Thread Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)
>This doesn't seem appropriate at all. If anything UC addresses >should be blocked and the Intel driver change reverted. We have >a well defined way to add secondary UC addresses and the MC interfaces >are not it. As I understand by ‘well defined way’ you mean macvlan feature. But macvlan is mo

Re: [PATCH v2] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc

2020-08-17 Thread David Miller
From: Denys Zagorui Date: Mon, 17 Aug 2020 10:52:24 -0700 > SIOCADDMULTI API allows adding multicast/unicast mac addresses but > doesn't deferentiate them so if someone tries to add secondary > unicast mac addr it will be added to multicast netdev list which is > confusing. There is at least one

[PATCH v2] net: core: SIOCADDMULTI/SIOCDELMULTI distinguish between uc and mc

2020-08-17 Thread Denys Zagorui
SIOCADDMULTI API allows adding multicast/unicast mac addresses but doesn't deferentiate them so if someone tries to add secondary unicast mac addr it will be added to multicast netdev list which is confusing. There is at least one user that allows adding secondary unicast through this API. (2f41f33