Re: [PATCH v2] net/ncsi: Fix netlink registration

2020-11-12 Thread Jakub Kicinski
On Thu, 12 Nov 2020 08:25:39 -0800 Samuel Mendoza-Jonas wrote: > On Thu, 2020-11-12 at 16:42 +1030, Joel Stanley wrote: > > If a user unbinds and re-binds a NC-SI aware driver the kernel will > > attempt to register the netlink interface at runtime. The structure > > is > > marked __ro_after_init s

Re: [PATCH v2] net/ncsi: Fix netlink registration

2020-11-12 Thread Samuel Mendoza-Jonas
On Thu, 2020-11-12 at 16:42 +1030, Joel Stanley wrote: > If a user unbinds and re-binds a NC-SI aware driver the kernel will > attempt to register the netlink interface at runtime. The structure > is > marked __ro_after_init so registration fails spectacularly at this > point. Reviewed-by: Samuel

[PATCH v2] net/ncsi: Fix netlink registration

2020-11-11 Thread Joel Stanley
If a user unbinds and re-binds a NC-SI aware driver the kernel will attempt to register the netlink interface at runtime. The structure is marked __ro_after_init so registration fails spectacularly at this point. # echo 1e66.ethernet > /sys/bus/platform/drivers/ftgmac100/unbind # echo 1e6600