Re: [PATCH v2] ipv6: esp6: use BUG_ON instead of if condition followed by BUG

2017-10-27 Thread Steffen Klassert
On Fri, Oct 27, 2017 at 06:38:36AM +0800, Herbert Xu wrote: > On Thu, Oct 26, 2017 at 07:51:06AM -0500, Gustavo A. R. Silva wrote: > > Use BUG_ON instead of if condition followed by BUG in esp_remove_trailer. > > > > This issue was detected with the help of Coccinelle. > > > > Signed-off-by: Gust

Re: [PATCH v2] ipv6: esp6: use BUG_ON instead of if condition followed by BUG

2017-10-26 Thread Gustavo A. R. Silva
Quoting Herbert Xu : On Thu, Oct 26, 2017 at 07:51:06AM -0500, Gustavo A. R. Silva wrote: Use BUG_ON instead of if condition followed by BUG in esp_remove_trailer. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva Acked-by: Herbert Xu Thanks! -- G

Re: [PATCH v2] ipv6: esp6: use BUG_ON instead of if condition followed by BUG

2017-10-26 Thread Herbert Xu
On Thu, Oct 26, 2017 at 07:51:06AM -0500, Gustavo A. R. Silva wrote: > Use BUG_ON instead of if condition followed by BUG in esp_remove_trailer. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Herbert Xu -- Email: Herbert Xu Home Page

[PATCH v2] ipv6: esp6: use BUG_ON instead of if condition followed by BUG

2017-10-26 Thread Gustavo A. R. Silva
Use BUG_ON instead of if condition followed by BUG in esp_remove_trailer. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Update the code as suggested by Herbert Xu: ret = foo(); BUG_ON(ret); net/ipv6/esp6.c | 4 ++-- 1 file change