Re: [PATCH v2] ipv6: Use inbound ifaddr as source addresses for ICMPv6 errors

2016-08-31 Thread David Miller
From: Eli Cooper Date: Sun, 28 Aug 2016 11:34:06 +0800 > According to RFC 1885 2.2(c), the source address of ICMPv6 > errors in response to forwarded packets should be set to the > unicast address of the forwarding interface in order to be helpful > in diagnosis. Currently the selection of source

Re: [PATCH v2] ipv6: Use inbound ifaddr as source addresses for ICMPv6 errors

2016-08-30 Thread Guillaume Nault
On Mon, Aug 29, 2016 at 02:34:32AM +0800, Eli Cooper wrote: > Hello, > > > On 2016/8/29 1:18, Guillaume Nault wrote: > > On Sun, Aug 28, 2016 at 11:34:06AM +0800, Eli Cooper wrote: > >> According to RFC 1885 2.2(c), the source address of ICMPv6 > >> errors in response to forwarded packets should

Re: [PATCH v2] ipv6: Use inbound ifaddr as source addresses for ICMPv6 errors

2016-08-28 Thread Eli Cooper
Hello, On 2016/8/29 1:18, Guillaume Nault wrote: > On Sun, Aug 28, 2016 at 11:34:06AM +0800, Eli Cooper wrote: >> According to RFC 1885 2.2(c), the source address of ICMPv6 >> errors in response to forwarded packets should be set to the >> unicast address of the forwarding interface in order to b

Re: [PATCH v2] ipv6: Use inbound ifaddr as source addresses for ICMPv6 errors

2016-08-28 Thread Guillaume Nault
On Sun, Aug 28, 2016 at 11:34:06AM +0800, Eli Cooper wrote: > According to RFC 1885 2.2(c), the source address of ICMPv6 > errors in response to forwarded packets should be set to the > unicast address of the forwarding interface in order to be helpful > in diagnosis. > FWIW, this behaviour has be

[PATCH v2] ipv6: Use inbound ifaddr as source addresses for ICMPv6 errors

2016-08-27 Thread Eli Cooper
According to RFC 1885 2.2(c), the source address of ICMPv6 errors in response to forwarded packets should be set to the unicast address of the forwarding interface in order to be helpful in diagnosis. Currently the selection of source address is based on the default route, without respect to the in