Re: [PATCH v2] ipv6: Fix protocol resubmission

2015-06-02 Thread Josh Hunt
On 05/29/2015 09:37 PM, Josh Hunt wrote: On 05/29/2015 04:48 PM, Tom Herbert wrote: Hi Josh, Why did you need to move the resubmit label? Grabbing nhoff out of the skb's cb didn't seem relevant anymore, unless we're requiring the decapsulating code to update the control block before it return

Re: [PATCH v2] ipv6: Fix protocol resubmission

2015-05-29 Thread Josh Hunt
On 05/29/2015 04:48 PM, Tom Herbert wrote: Hi Josh, Why did you need to move the resubmit label? Grabbing nhoff out of the skb's cb didn't seem relevant anymore, unless we're requiring the decapsulating code to update the control block before it returns. Also, since we are returning nexthdr

Re: [PATCH v2] ipv6: Fix protocol resubmission

2015-05-29 Thread Tom Herbert
Hi Josh, Why did you need to move the resubmit label? On Fri, May 29, 2015 at 2:43 PM, Josh Hunt wrote: > On 05/29/2015 03:27 PM, Sergei Shtylyov wrote: >> >> Hello. >> >> On 05/29/2015 11:04 PM, Josh Hunt wrote: >> >>> I came across this problem while trying to use UDP encapsulation with >>> I

Re: [PATCH v2] ipv6: Fix protocol resubmission

2015-05-29 Thread Josh Hunt
On 05/29/2015 03:27 PM, Sergei Shtylyov wrote: Hello. On 05/29/2015 11:04 PM, Josh Hunt wrote: I came across this problem while trying to use UDP encapsulation with IPv6. The change below fixes that, but it was not immediately apparent if there are any other protocols relying on this broken be

Re: [PATCH v2] ipv6: Fix protocol resubmission

2015-05-29 Thread Sergei Shtylyov
Hello. On 05/29/2015 11:04 PM, Josh Hunt wrote: I came across this problem while trying to use UDP encapsulation with IPv6. The change below fixes that, but it was not immediately apparent if there are any other protocols relying on this broken behavior. FWIW the behavior below now matches IPv4

[PATCH v2] ipv6: Fix protocol resubmission

2015-05-29 Thread Josh Hunt
I came across this problem while trying to use UDP encapsulation with IPv6. The change below fixes that, but it was not immediately apparent if there are any other protocols relying on this broken behavior. FWIW the behavior below now matches IPv4. Josh v2: Actually sets nexthdr so we can use it