Re: [PATCH v2] hv_sock: Add support for delayed close

2019-05-16 Thread David Miller
From: Sunil Muthuswamy Date: Wed, 15 May 2019 00:56:05 + > Currently, hvsock does not implement any delayed or background close > logic. Whenever the hvsock socket is closed, a FIN is sent to the peer, and > the last reference to the socket is dropped, which leads to a call to > .destruct whe

RE: [PATCH v2] hv_sock: Add support for delayed close

2019-05-16 Thread Dexuan Cui
> From: Sunil Muthuswamy > Sent: Thursday, May 16, 2019 11:11 AM > > Hi Sunil, > > To make it clear, your patch itself is good, and I was just talking about > > the next change we're going to make. Once we make the next change, > > IMO we need a further patch to schedule hvs_close_timeout() to the

RE: [PATCH v2] hv_sock: Add support for delayed close

2019-05-16 Thread Sunil Muthuswamy
.@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: RE: [PATCH v2] hv_sock: Add support for delayed close > > > From: linux-hyperv-ow...@vger.kernel.org > > On Behalf Of Dexuan Cui > > Sent: Wednesday, May 15, 2019 9:34 PM > > ... > > Hi Sunil, >

RE: [PATCH v2] hv_sock: Add support for delayed close

2019-05-16 Thread Dexuan Cui
> From: linux-hyperv-ow...@vger.kernel.org > On Behalf Of Dexuan Cui > Sent: Wednesday, May 15, 2019 9:34 PM > ... Hi Sunil, To make it clear, your patch itself is good, and I was just talking about the next change we're going to make. Once we make the next change, IMO we need a further patch to

RE: [PATCH v2] hv_sock: Add support for delayed close

2019-05-15 Thread Dexuan Cui
> From: Sunil Muthuswamy > Sent: Tuesday, May 14, 2019 5:56 PM > ... > +static bool hvs_close_lock_held(struct vsock_sock *vsk) > { > ... > + schedule_delayed_work(&vsk->close_work, HVS_CLOSE_TIMEOUT); Reviewed-by: Dexuan Cui The patch looks good to me. Thank you, Sunil! Next, we're going

[PATCH v2] hv_sock: Add support for delayed close

2019-05-14 Thread Sunil Muthuswamy
Currently, hvsock does not implement any delayed or background close logic. Whenever the hvsock socket is closed, a FIN is sent to the peer, and the last reference to the socket is dropped, which leads to a call to .destruct where the socket can hang indefinitely waiting for the peer to close it's