Re: [PATCH v2] ethtool: Add bash-completion script

2019-04-18 Thread John W. Linville
On Tue, Apr 16, 2019 at 08:53:33PM -0600, Kevin Locke wrote: > On Tue, 2019-04-16 at 14:37 -0400, John W. Linville wrote: > > Overall, it looks good to me. But when I build with "make distcheck", > > I get this output: > > > > [...] > > > > It looks like somewhere you are using "$(bashcompletiond

Re: [PATCH v2] ethtool: Add bash-completion script

2019-04-16 Thread Kevin Locke
On Tue, 2019-04-16 at 14:37 -0400, John W. Linville wrote: > Overall, it looks good to me. But when I build with "make distcheck", > I get this output: > > [...] > > It looks like somewhere you are using "$(bashcompletiondir)" instead of > "$(DESTDIR)$(bashcompletiondir)", but I can't seem to fin

Re: [PATCH v2] ethtool: Add bash-completion script

2019-04-16 Thread John W. Linville
On Thu, Apr 11, 2019 at 11:39:32AM -0600, Kevin Locke wrote: > To aid users constructing a valid ethtool invocation, create a > [bash-completion] script to provide [programmable completion] of ethtool > arguments. It supports all current command options. > > The script is named shell-completion/b

[PATCH v2] ethtool: Add bash-completion script

2019-04-11 Thread Kevin Locke
To aid users constructing a valid ethtool invocation, create a [bash-completion] script to provide [programmable completion] of ethtool arguments. It supports all current command options. The script is named shell-completion/bash/ethtool, similar to [kmod], and installed to `pkg-config --variable