Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2017-04-25 Thread Niklas Cassel
On 04/18/2017 06:40 PM, Florian Fainelli wrote: > On 04/18/2017 06:23 AM, Niklas Cassel wrote: >> On 01/04/2017 03:33 PM, Florian Fainelli wrote: >>> On 12/02/2016 09:48 AM, Florian Fainelli wrote: >> Peppe, any thoughts on this? > > I share what you say. > > In sum, the EEE m

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2017-04-18 Thread Florian Fainelli
On 04/18/2017 06:23 AM, Niklas Cassel wrote: > On 01/04/2017 03:33 PM, Florian Fainelli wrote: >> On 12/02/2016 09:48 AM, Florian Fainelli wrote: > Peppe, any thoughts on this? I share what you say. In sum, the EEE management inside the stmmac is: - the driver look

Re: Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2017-04-18 Thread Niklas Cassel
On 01/04/2017 03:33 PM, Florian Fainelli wrote: > On 12/02/2016 09:48 AM, Florian Fainelli wrote: Peppe, any thoughts on this? >>> >>> I share what you say. >>> >>> In sum, the EEE management inside the stmmac is: >>> >>> - the driver looks at own HW cap register if EEE is supported >>> >>>

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2017-01-04 Thread Florian Fainelli
On 12/02/2016 09:48 AM, Florian Fainelli wrote: >>> Peppe, any thoughts on this? >> >> I share what you say. >> >> In sum, the EEE management inside the stmmac is: >> >> - the driver looks at own HW cap register if EEE is supported >> >> (indeed the user could keep disable EEE if bugged on some

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2016-12-02 Thread Florian Fainelli
On 12/02/2016 01:11 AM, Giuseppe CAVALLARO wrote: > Hi Florian > sorry for my delay. > > On 11/24/2016 7:23 PM, Florian Fainelli wrote: >> +Peppe, >> >> Le 24/11/2016 à 07:38, Andrew Lunn a écrit : As for enabling advertising and correct working of cpsw do you mean it would be better to

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2016-12-02 Thread Giuseppe CAVALLARO
Hi Florian sorry for my delay. On 11/24/2016 7:23 PM, Florian Fainelli wrote: +Peppe, Le 24/11/2016 à 07:38, Andrew Lunn a écrit : As for enabling advertising and correct working of cpsw do you mean it would be better to disable EEE in any PHY on cpsw initialization as long as cpsw doesn't pro

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2016-11-24 Thread Florian Fainelli
+Peppe, Le 24/11/2016 à 07:38, Andrew Lunn a écrit : >> As for enabling advertising and correct working of cpsw do you mean it >> would be better to disable EEE in any PHY on cpsw initialization as >> long as cpsw doesn't provide support for EEE? >> >> We observe some strange behavior with our gig

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2016-11-24 Thread Andrew Lunn
> As for enabling advertising and correct working of cpsw do you mean it > would be better to disable EEE in any PHY on cpsw initialization as > long as cpsw doesn't provide support for EEE? > > We observe some strange behavior with our gigabit PHYs and a link > partner in a EEE-capable unmanaged

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2016-11-24 Thread Yegor Yefremov
On Wed, Nov 23, 2016 at 9:15 PM, Florian Fainelli wrote: > On 11/23/2016 12:08 PM, Yegor Yefremov wrote: >> On Wed, Nov 23, 2016 at 6:33 PM, Florian Fainelli >> wrote: >>> On 11/23/2016 06:38 AM, yegorsli...@googlemail.com wrote: From: Yegor Yefremov Add the ability to query and

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2016-11-23 Thread Florian Fainelli
On 11/23/2016 12:08 PM, Yegor Yefremov wrote: > On Wed, Nov 23, 2016 at 6:33 PM, Florian Fainelli > wrote: >> On 11/23/2016 06:38 AM, yegorsli...@googlemail.com wrote: >>> From: Yegor Yefremov >>> >>> Add the ability to query and set Energy Efficient Ethernet parameters >>> via ethtool for appli

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2016-11-23 Thread Yegor Yefremov
On Wed, Nov 23, 2016 at 6:33 PM, Florian Fainelli wrote: > On 11/23/2016 06:38 AM, yegorsli...@googlemail.com wrote: >> From: Yegor Yefremov >> >> Add the ability to query and set Energy Efficient Ethernet parameters >> via ethtool for applicable devices. > > Are you sure this is enough to actual

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2016-11-23 Thread Florian Fainelli
On 11/23/2016 06:38 AM, yegorsli...@googlemail.com wrote: > From: Yegor Yefremov > > Add the ability to query and set Energy Efficient Ethernet parameters > via ethtool for applicable devices. Are you sure this is enough to actually enable EEE? I don't see where phy_init_eee() is called here, no

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2016-11-23 Thread Rami Rosen
Acked-by: Rami Rosen

[PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2016-11-23 Thread yegorslists
From: Yegor Yefremov Add the ability to query and set Energy Efficient Ethernet parameters via ethtool for applicable devices. Signed-off-by: Yegor Yefremov --- Changes: v2: make routines static (Rami Rosen) drivers/net/ethernet/ti/cpsw.c | 26 ++ 1 file change