; netdev@vger.kernel.org; linux-...@vger.kernel.org;
> geert+rene...@glider.be; Chris Paterson
> Subject: Re: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver
>
> Hello Ramesh,
>
> please send out a new v3 patchset to trigger the process again :-)
>
> Best regards,
> O
;
cor...@lwn.net
Cc: linux-renesas-...@vger.kernel.org; devicet...@vger.kernel.org; linux-
c...@vger.kernel.org; netdev@vger.kernel.org; linux-...@vger.kernel.org;
geert+rene...@glider.be; Chris Paterson
Subject: RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver
Hi Marc,
Thanks for
g; netdev@vger.kernel.org; linux-...@vger.kernel.org;
> geert+rene...@glider.be; Chris Paterson
> Subject: RE: [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver
>
> Hi Marc,
>
> Thanks for your time & review comments.
>
> > -Original Message-
> (...)
Hi Marc,
Thanks for your time & review comments.
> -Original Message-
(...)
> > +#define RCANFD_NAPI_WEIGHT 8 /* Rx poll quota */
> > +
> > +#define RCANFD_NUM_CHANNELS2
> > +#define RCANFD_CHANNELS_MASK 0x3 /* Two channels max */
>
> (BIT(
On 03/03/2016 04:38 PM, Ramesh Shanmugasundaram wrote:
> This patch adds support for the CAN FD controller found in Renesas R-Car
> SoCs. The controller operates in CAN FD mode by default.
>
> CAN FD mode supports both Classical CAN & CAN FD frame formats. The
> controller supports ISO 11898-1:201
Hi Ramesh,
On 03/11/2016 08:14 AM, Ramesh Shanmugasundaram wrote:
As we are fixing this issue in CAN dev.c, I'll remove this check in ndo_open and
set CAN_CTRLMODE_FD flag in ctrlmode & remove the flag in ctrlmode_supported in
the next v3 version of the patch.
I posted a V2 version of that
Hi Oliver, Marc,
> On 03/08/2016 01:48 PM, Ramesh Shanmugasundaram wrote:
>
> >> In fact you provided a CAN driver which is "CAN-FD-only".
> >
> > Yes. That's the status of current submission.
(...)
> >
> > I did try this option earlier but there are two problems with this
> method.
> >
> > 1)
On 03/08/2016 01:48 PM, Ramesh Shanmugasundaram wrote:
>> In fact you provided a CAN driver which is "CAN-FD-only".
>
> Yes. That's the status of current submission.
>
>> We did not had that before but there's a solution for this kind of setup.
>>
>> There is a similar case with CAN_CTRLMODE_FD_
Hi Oliver,
Thanks for the comments.
> On 08.03.2016 09:57, Ramesh Shanmugasundaram wrote:
>
> >
> > As you mentioned further down, when a user does this
> >
> > "ip link set can0 up type can bitrate 100"
> >
> > the intention is to put the controller in CAN 2.0 mode. Even if we use a
> statu
Hi Ramesh,
On 08.03.2016 09:57, Ramesh Shanmugasundaram wrote:
As you mentioned further down, when a user does this
"ip link set can0 up type can bitrate 100"
the intention is to put the controller in CAN 2.0 mode. Even if we use a status
flag or copy the data bitrate equal to the nomin
Hi Oliver,
Thanks for the comments.
> On 03/07/2016 09:32 AM, Ramesh Shanmugasundaram wrote:
>
> > + /* Ensure channel starts in FD mode */
> > + if (!(priv->can.ctrlmode & CAN_CTRLMODE_FD)) {
> > + netdev_err(ndev, "enable can fd mode for channel %d\n",
> c
On 03/07/2016 09:32 AM, Ramesh Shanmugasundaram wrote:
> + /* Ensure channel starts in FD mode */
> + if (!(priv->can.ctrlmode & CAN_CTRLMODE_FD)) {
> + netdev_err(ndev, "enable can fd mode for channel %d\n", ch);
> + goto fail_mode;
> + }
What's the
Hi Rob,
Thanks for the review comments.
> On Thu, Mar 03, 2016 at 03:38:35PM +, Ramesh Shanmugasundaram wrote:
> > This patch adds support for the CAN FD controller found in Renesas
> > R-Car SoCs. The controller operates in CAN FD mode by default.
> >
> > CAN FD mode supports both Classical
Hi Marc,
> On 03/07/2016 09:02 AM, Ramesh Shanmugasundaram wrote:
> > Hi Oliver,
> >
> > Thanks for the review comments.
> >
> >> On 03/03/2016 04:38 PM, Ramesh Shanmugasundaram wrote:
> >>
> >>> Changes since v1:
> >>> * Removed testmodes & debugfs code (suggested by Oliver H)
> >>> * Fixed t
On 03/07/2016 09:02 AM, Ramesh Shanmugasundaram wrote:
> Hi Oliver,
>
> Thanks for the review comments.
>
>> On 03/03/2016 04:38 PM, Ramesh Shanmugasundaram wrote:
>>
>>> Changes since v1:
>>> * Removed testmodes & debugfs code (suggested by Oliver H)
>>> * Fixed tx path race issue by int
Hi Oliver,
Thanks for the review comments.
> On 03/03/2016 04:38 PM, Ramesh Shanmugasundaram wrote:
>
> > Changes since v1:
> > * Removed testmodes & debugfs code (suggested by Oliver H)
> > * Fixed tx path race issue by introducing lock (suggested by Marc K)
> > * Removed __maybe_un
On 03/03/2016 04:38 PM, Ramesh Shanmugasundaram wrote:
> Changes since v1:
> * Removed testmodes & debugfs code (suggested by Oliver H)
> * Fixed tx path race issue by introducing lock (suggested by Marc K)
> * Removed __maybe_unused attribute of rcar_canfd_of_table
>
> obj-$
On Thu, Mar 03, 2016 at 03:38:35PM +, Ramesh Shanmugasundaram wrote:
> This patch adds support for the CAN FD controller found in Renesas R-Car
> SoCs. The controller operates in CAN FD mode by default.
>
> CAN FD mode supports both Classical CAN & CAN FD frame formats. The
> controller suppor
This patch adds support for the CAN FD controller found in Renesas R-Car
SoCs. The controller operates in CAN FD mode by default.
CAN FD mode supports both Classical CAN & CAN FD frame formats. The
controller supports ISO 11898-1:2015 CAN FD format only.
This controller supports two channels and
19 matches
Mail list logo
