Re: [PATCH v2] can: bcm: check timer values before ktime conversion

2019-01-22 Thread Marc Kleine-Budde
On 1/13/19 7:31 PM, Oliver Hartkopp wrote: > Kyungtae Kim detected a potential integer overflow in bcm_[rx|tx]_setup() > when the conversion into ktime multiplies the given value with NSEC_PER_USEC > (1000). > > Reference: https://marc.info/?l=linux-can&m=154732118819828&w=2 > > Add a check for t

Re: [PATCH v2] can: bcm: check timer values before ktime conversion

2019-01-17 Thread Oliver Hartkopp
Hello Marc, I would like to provide a stable patch for pre-4.18 kernels and need a commit hash as reference. Would you like to take that patch into upstream? Best regards, Oliver On 1/16/19 2:31 PM, Andre Naujoks wrote: Am 13.01.19 um 19:31 schrieb Oliver Hartkopp: Kyungtae Kim detected a

Re: [PATCH v2] can: bcm: check timer values before ktime conversion

2019-01-16 Thread Oliver Hartkopp
Hi Sasha, some more details ... On 1/16/19 2:36 PM, Sasha Levin wrote: This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: 2.6.26+ v4.9.150: Build OK! v4.4.170: Failed to apply! Possible dependencies:

Re: [PATCH v2] can: bcm: check timer values before ktime conversion

2019-01-16 Thread Oliver Hartkopp
Hi Sasha, On 1/16/19 2:36 PM, Sasha Levin wrote: Hi, [This is an automated email] This commit has been processed because it contains a -stable tag. The stable tag indicates that it's relevant for the following trees: 2.6.26+ The bot has tested the following trees: v4.20.2, v4.19.15, v4.14.93,

Re: [PATCH v2] can: bcm: check timer values before ktime conversion

2019-01-16 Thread Andre Naujoks
Am 13.01.19 um 19:31 schrieb Oliver Hartkopp: > Kyungtae Kim detected a potential integer overflow in bcm_[rx|tx]_setup() > when the conversion into ktime multiplies the given value with NSEC_PER_USEC > (1000). > > Reference: https://marc.info/?l=linux-can&m=154732118819828&w=2 > > Add a check fo

Re: [PATCH v2] can: bcm: check timer values before ktime conversion

2019-01-16 Thread Kyungtae Kim
On Sun, Jan 13, 2019 at 1:31 PM Oliver Hartkopp wrote: > > Kyungtae Kim detected a potential integer overflow in bcm_[rx|tx]_setup() > when the conversion into ktime multiplies the given value with NSEC_PER_USEC > (1000). > > Reference: https://marc.info/?l=linux-can&m=154732118819828&w=2 > > Add

[PATCH v2] can: bcm: check timer values before ktime conversion

2019-01-13 Thread Oliver Hartkopp
Kyungtae Kim detected a potential integer overflow in bcm_[rx|tx]_setup() when the conversion into ktime multiplies the given value with NSEC_PER_USEC (1000). Reference: https://marc.info/?l=linux-can&m=154732118819828&w=2 Add a check for the given tv_usec, so that the value stays below one secon